Merge pull request #72 from velocitycareerlabs/dev-to-rc

Dev to rc
velocitycareerlabs · Dec 26, 2023 · b7ac542 · b7ac542
2 parents 3e4ff67 + 5ee9a95
commit b7ac542
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/VCL/build.gradle b/VCL/build.gradle
@@ -13,7 +13,7 @@ android {
     defaultConfig {
         minSdk 24
         targetSdk 33
-        versionName "1.22.0"
+        versionName "1.22.2"
         versionCode 118
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         consumerProguardFiles "consumer-rules.pro"

diff --git a/...main/java/io/velocitycareerlabs/api/entities/VCLCredentialManifestDescriptorByDeepLink.kt b/...main/java/io/velocitycareerlabs/api/entities/VCLCredentialManifestDescriptorByDeepLink.kt
@@ -10,9 +10,11 @@ package io.velocitycareerlabs.api.entities
 class VCLCredentialManifestDescriptorByDeepLink(
     deepLink: VCLDeepLink,
     issuingType: VCLIssuingType = VCLIssuingType.Career,
+    pushDelegate: VCLPushDelegate? = null
 ): VCLCredentialManifestDescriptor(
     uri = deepLink.requestUri,
     issuingType = issuingType,
+    pushDelegate = pushDelegate,
     vendorOriginContext = deepLink.vendorOriginContext,
     deepLink = deepLink
 )
diff --git a/...test/java/io/velocitycareerlabs/entities/VCLCredentialManifestDescriptorByDeepLinkTest.kt b/...test/java/io/velocitycareerlabs/entities/VCLCredentialManifestDescriptorByDeepLinkTest.kt
@@ -9,6 +9,7 @@ package io.velocitycareerlabs.entities
 
 import io.velocitycareerlabs.api.entities.VCLCredentialManifestDescriptorByDeepLink
 import io.velocitycareerlabs.api.entities.VCLIssuingType
+import io.velocitycareerlabs.api.entities.VCLPushDelegate
 import io.velocitycareerlabs.impl.extensions.decode
 import io.velocitycareerlabs.impl.extensions.isUrlEquivalentTo
 import io.velocitycareerlabs.infrastructure.resources.valid.CredentialManifestDescriptorMocks
@@ -29,14 +30,17 @@ internal class VCLCredentialManifestDescriptorByDeepLinkTest {
     fun testCredentialManifestDescriptorFullValidByDeepLinkSuccess() {
         subject = VCLCredentialManifestDescriptorByDeepLink(
             deepLink = CredentialManifestDescriptorMocks.DeepLink,
-            issuingType = VCLIssuingType.Career
+            issuingType = VCLIssuingType.Career,
+            pushDelegate = VCLPushDelegate(pushUrl = "some url", pushToken = "some token")
         )
 
         assert(
             subject.endpoint?.decode()
                 ?.isUrlEquivalentTo(CredentialManifestDescriptorMocks.DeepLinkRequestUri.decode()) == true
         )
         assert(subject.did == CredentialManifestDescriptorMocks.IssuerDid)
+        assert(subject.pushDelegate?.pushUrl == "some url")
+        assert(subject.pushDelegate?.pushToken == "some token")
     }
 
     @After