Cleanup

velocitycareerlabs · Dec 13, 2023 · f970b7f · f970b7f
1 parent b68353d
commit f970b7f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 26 deletions.
diff --git a/.github/workflows/android-sdk.yml b/.github/workflows/android-sdk.yml
@@ -19,24 +19,24 @@ env:
   ANDROID_NEXUS_STAGING_PROFILE_ID: ${{ secrets.ANDROID_NEXUS_STAGING_PROFILE_ID }}
   ANDROID_NEXUS_PRIVATE_KEY: ${{ secrets.ANDROID_NEXUS_PRIVATE_KEY }}
 jobs:
-  # test-android-sdk:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - name: Git clone repository
-  #       uses: actions/checkout@v4
-  #     # Setup java
-  #     - uses: actions/setup-java@v3
-  #       with:
-  #         distribution: temurin
-  #         java-version: ${{ env.JAVA_VERSION }}
-  #     # Run test
-  #     - name: Run Test
-  #       run: ./gradlew test
+  test-android-sdk:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Git clone repository
+        uses: actions/checkout@v4
+      # Setup java
+      - uses: actions/setup-java@v3
+        with:
+          distribution: temurin
+          java-version: ${{ env.JAVA_VERSION }}
+      # Run test
+      - name: Run Test
+        run: ./gradlew test
 
   build-android-sdk:
     runs-on: ubuntu-latest
-    # needs: 
-    #   - test-android-sdk
+    needs: 
+      - test-android-sdk
     steps:
       - name: Git clone repository
         uses: actions/checkout@v4

diff --git a/VCL/build.gradle b/VCL/build.gradle
@@ -13,7 +13,7 @@ android {
     defaultConfig {
         minSdk 24
         targetSdk 33
-        versionName "1.21.2"
+        versionName "1.21.3"
         versionCode 116
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         consumerProguardFiles "consumer-rules.pro"
@@ -106,8 +106,10 @@ afterEvaluate {
             rc(MavenPublication) {
                 groupId getGroupId()
                 artifactId getArtifactId()
+
+                // define rc version name
                 def rc = getVersionName()
-                version = "${rc}-rc"
+                version = "${rc}-RC"
 
                 // Two artifacts, the `aar` (or `jar`) and the sources
                 if (project.plugins.findPlugin("com.android.library")) {
@@ -212,15 +214,6 @@ afterEvaluate {
     }
 }
 
-// signing {
-//     useInMemoryPgpKeys(
-//             rootProject.ext.signingKeyId,
-//             rootProject.ext.signingPrivateKey,
-//             rootProject.ext.signingPassword,
-//     )
-//     sign publishing.publications
-// }
-
 repositories {
     mavenCentral()
 }

diff --git a/build.gradle b/build.gradle
@@ -16,6 +16,7 @@ buildscript {
 
 plugins {
     // Automation plugin
+    // https://github.com/gradle-nexus/publish-plugin
     id "io.github.gradle-nexus.publish-plugin" version "1.1.0"
 }