Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.2 logs #94

Merged
merged 1 commit into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions VCL/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ android {
defaultConfig {
minSdk 24
targetSdk 33
versionName "2.3.1"
versionCode 131
versionName "2.3.2"
versionCode 132
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles "consumer-rules.pro"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,12 @@ internal class CredentialIssuerVerifierImpl(
// https://velocitycareerlabs.atlassian.net/browse/VL-6178?focusedCommentId=46933
// https://velocitycareerlabs.atlassian.net/browse/VL-6988
// if (jwtCredential.iss == did)
if (Utils.getCredentialIssuerId(jwtCredential) == did) {
val credentialIssuerId = Utils.getCredentialIssuerId(jwtCredential)
VCLLog.d(
TAG,
"Comparing credentialIssuerId: ${credentialIssuerId ?: ""} with did: $did"
)
if (credentialIssuerId == did) {
isCredentialVerified = true
} else {
globalError =
Expand All @@ -263,11 +268,21 @@ internal class CredentialIssuerVerifierImpl(
} ?: run {
globalError =
VCLError(errorCode = VCLErrorCode.IssuerRequiresNotaryPermission.value)

VCLLog.e(
TAG,
"DID NOT FOUND for K = $K and credentialSubject = $credentialSubject"
)
}
} ?: run {
// When K is null, the credential will pass these checks:
// https://velocitycareerlabs.atlassian.net/browse/VL-6181?focusedCommentId=44343
isCredentialVerified = true

VCLLog.d(
TAG,
"Key for primary organization NOT FOUND for active context:\n$activeContext"
)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ import org.junit.Before
import org.junit.Test

internal class CredentialIssuerVerifierTest {
val TAG = CredentialIssuerVerifierTest::class.simpleName

private lateinit var subject1: CredentialIssuerVerifier
private lateinit var subject2: CredentialIssuerVerifier
private lateinit var subject3: CredentialIssuerVerifier
Expand Down
Loading