Improving checkout translations #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a couple of issues reported by a client with Vendr Checkout translations.
As the master template prevents property model errors from being rendered (
@Html.ValidationSummary(true)) the invalid discount code message just displayed an empty box - I have set the property to an empty string for this error messageUpon fixing the invalid discount code message we discovered it wasn't translatable via a dictionary value - I have added a
VendrCheckout.Information.InvalidDiscountGiftCodedictionary key that can be used to override the defaultThe default values for the prev / next buttons did not include the step name - the
{0}placeholder had been missed off the dictionary fallback value. I see this was recently fixed in d732121 for Vendr Checkout V2.The step name in the prev / next buttons usually has a capital letter at the start, given as it is a node name. This looks a bit odd, e.g. "Continue to Shipping method", so I have
.ToLower()'d step names for a more natural read.I appreciate this PR is targeted to Vendr Checkout V1, simply because this is what affects our client. It should be easy to merge these changes up to Vendr Checkout V2 also!