Fix server crash when upload failed on Youtube

Server was crashing when Youtube returned an error
on an upload. The error returned by Youtube in the
request body wasn't analyzed.

CHANGELOG.md

@@ -1,3 +1,9 @@
+# 9.0.2 / YYYY-MM-DD
+
+## BUG FIXES
+
+- Fix server crash when uploading on Youtube failed
+
 # 9.0.1 / 2018-11-16
 
 ## BUG FIXES

app/server/providers/mediaPlatforms/youtube/YoutubeProvider.js

@@ -241,7 +241,7 @@ YoutubeProvider.prototype.uploadResumable = function(mediaFilePath, uploadParams
         process.logger.debug('Upload progress', progress);
       });
       resumableUpload.on('error', function(error) {
-        process.logger.debug('Upload error', error);
+        process.logger.error('Upload error', error && error.message);
         if (resumableUpload.retry === 0) {
           callback(error);
         }

app/server/providers/mediaPlatforms/youtube/YoutubeResumableUpload.js

@@ -109,15 +109,25 @@ ResumableUpload.prototype.upload = function() {
 
   // Send request and start upload if success
   request.post(options, function(err, res, body) {
+    if (body) {
+      body = JSON.parse(body);
+
+      if (body.error) {
+        self.retry = 0;
+        self.emit('error', new Error(body.error.message));
+        return;
+      }
+    }
+
     if (err || !res.headers.location) {
-      self.emit('error', new Error(err));
+      self.emit('error', err);
       if ((self.retry > 0) || (self.retry <= -1)) {
         self.emit('progress', 'Retrying ...');
         self.retry--;
         self.upload();// retry
       } else {
         if (err)
-          self.emit('error', new Error(err));
+          self.emit('error', err);
         else
           self.emit('error', new Error('max try reached'));
         return;