Optional timeout #77
Merged
Optional timeout #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value is None, so the current default behavior remains unchanged
The default value is None, which means the default behavior remains unchanged
The default value is None, which means the default behavior remains unchanged
|
LGTM! IMO having a timeout variable on the Maybe next year. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposed solution to #67. The newly added timeout parameter is None by default, so the default behavior remains unchanged, but gives the option to add a timeout to those who wish to use one.
Originally I had added a
timeoutvariable to theAPIclass, but after thinking about it for awhile, I believe making the timeout an argument onpublic_queryandprivate_querymethods is a better solution, and this PR adopts that stance. Having to specify the timeout on each request is a little bit more verbose, but makes it easier to specify timeouts independently and dynamically for each endpoint.