Update custom algorithms example #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
requested review from
henkbirkholz,
qmuntal,
roywill,
setrofim,
shizhMSFT,
SimonFrost-Arm,
SteveLasker,
thomas-fossati and
yogeshbdeshpande
as code owners
Signed-off-by: Orie Steele <[email protected]>
OR13
force-pushed
the
custom-signer-example
branch
from
d153ce2 to
223b104
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 92.35% 91.27% -1.09%
==========================================
Files 12 12
Lines 1622 2005 +383
==========================================
+ Hits 1498 1830 +332
- Misses 68 119 +51
Partials 56 56 ☔ View full report in Codecov by Sentry. |
|
Thanks @OR13, |
thomas-fossati
approved these changes
Nov 22, 2024
Comment on lines
+284
to
+286
| verify_error := sign1.Verify(nil, verifier) | ||
|
|
||
| if verify_error != nil { |
There was a problem hiding this comment.
usual golang typo conventions
Suggested change
| verify_error := sign1.Verify(nil, verifier) | |
| if verify_error != nil { | |
| verifyError := sign1.Verify(nil, verifier) | |
| if verifyError != nil { |
| if verify_error != nil { | ||
| t.Fatalf("Verification failed") | ||
| } else { | ||
| // fmt.Println(cbor.Diagnose(signature)) |
There was a problem hiding this comment.
This is a beauty, isn't it?
| var payload = []byte("hello post quantum signatures") | ||
| signature, _ := cose.Sign1(nil, ks, headers, payload, nil) | ||
| var sign1 cose.Sign1Message | ||
| sign1.UnmarshalCBOR(signature) |
There was a problem hiding this comment.
maybe ignore error more explicitly:
Suggested change
| sign1.UnmarshalCBOR(signature) | |
| _ = sign1.UnmarshalCBOR(signature) |
|
Ping to @OR13 if you'd like to make the changes Thomas suggested #209 (comment) |
|
@thomas-fossati, I see you approved the PR, but left some open comments/suggestions. If you and @OR13 can arrive at a consensus, we can merge, or close the pr. |
shizhMSFT
reviewed
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the readme section describing custom algorithms, and provides an example test.
The current instructions in this section are not very helpful:
https://github.com/search?q=repo%3Averaison%2Fgo-cose%20RegisterAlgorithm&type=code