Aws #280
Merged
Aws #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DEPLOYMENT_DEST configuration variable that specifies the location where the deployment will be generated. This defaults to VERAISON_ROOT (the install location of the deployment), but may be set to a different value, allowing the deployment to be created in an intermediate location before being moved into its final installation destination. This is useful when the native deployment is intended to be used as an input for an alternative deployment mechanism (e.g. a Debian package) rather than being used directly. Signed-off-by: Sergei Trofimov <[email protected]>
Up to now, the version reported by Veraison services was set during build to "commit-$commit" where $commit is the short hash of the HEAD commit during the build. Since 9509e74, we now have regular auto-tagging on the repo in the form "v0.0.yyMM". This should be included in the version. This commit adds scrips/get-veraison-version that generates a version of the form "$version+$commit" where $version is the version from tag sans the leading "v". It also allows overriding this version using VERAISON_BUILD_VERSION environment variable. The override may be useful when git is not available (e.g. when building form a tarball) or when wanting to encode additional information in the version (e.g. when creating a build for a specific demo). This script is then used to populate VERSION_FROM_GIT inside mk/common.mk which is then compiled into the built executables. Signed-off-by: Sergei Trofimov <[email protected]>
Allow installing Veraison services into the system services manager under systemd using -s option (the default is to use the user service manager). Signed-off-by: Sergei Trofimov <[email protected]>
Add "debian" deployment that generates a .deb package that can be installed on Debian and Ubuntu systems. Signed-off-by: Sergei Trofimov <[email protected]>
thomas-fossati
approved these changes
Nov 13, 2024
end-to-end/README.md
Outdated
| @@ -4,7 +4,8 @@ All the instructions on this page refer to the Docker-based deployment. To use | |||
| the native deployment, just substitute "docker" with "native" in all the | |||
| commands given below. For example, `make native-deploy` instead of `make | |||
| docker-deploy`, and `./end-to-end-native provision` instead of `./end-to-end-docker | |||
| provision` | |||
| provision`. The same applies to `./end-to-end-aws` with the proviso that | |||
There was a problem hiding this comment.
Did you mean the same applies to aws meaning replace in all scripts with aws instead of using docker? It is not super clear whether the guidance is specific to ./end-to-end command or it follows from the previous text. Could you please clarify the wording?
- Add scripts for deploying Veraison into existing AWS VPC/subnets. - Update end-to-end with aws version. Signed-off-by: Sergei Trofimov <[email protected]>
yogeshbdeshpande
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS deployment.