fix :docs add docker-buildx installation step to requirements #288
Conversation
Priyanshuthapliyal2005
force-pushed
the
main
branch
2 times, most recently
from
2d616aa to
7d9c0c9
Compare
Signed-off-by: Priyanshu Thapliyal <[email protected]>
Priyanshuthapliyal2005
force-pushed
the
main
branch
from
7d9c0c9 to
fcdb37a
Compare
There was a problem hiding this comment.
Priyanshu, thanks very much for the contribution.
I have left a couple of suggestions in line.
Since we try to stick to conventional commits conventions, could you please also amend the commit message to read like:
fix(docs): add docker-buildx installation step to requirements
Thanks!
README.md
Outdated
|
|
||
| On Ubuntu you can do this with: | ||
|
|
||
| sudo apt install git docker.io jq tmux | ||
| sudo apt install docker-buildx |
There was a problem hiding this comment.
We could, more economically, add docker-buildx to L27 instead of using a separate apt install invocation.
There was a problem hiding this comment.
Thank you for the suggestions, Thomas! I have:
Moved the Docker Buildx plugin installation step below the Docker-related setup section to cluster the information more tightly.
Combined the docker-buildx installation into the same apt install line for better readability.
Updated the commit message to reflect the correct conventional format.
Please let me know if there's anything else to improve!
There was a problem hiding this comment.
Nice, thanks very much.
In the meantime, @Arnaud-de-Grandmaison-ARM has found an issue (and a fix) for a build issue that breaks the CI, see #290
When that PR is merged, you'll need to rebase your branch on top of main.
There was a problem hiding this comment.
Thank you for the update, @thomas-fossati! I’ll keep an eye on #290 and will rebase my branch on top of the main branch once the fix is merged.
There was a problem hiding this comment.
@thomas-fossati , I'm currently exploring some issues within the community to get more familiar with the organization. I've checked many repositories, and I've noticed that you are one of the most active mentors here. I would greatly appreciate it if you could suggest any specific issues or areas where I could contribute to improve and make a meaningful impact.
Thank you!
There was a problem hiding this comment.
I would greatly appreciate it if you could suggest any specific issues or areas where I could contribute to improve and make a meaningful impact.
It depends on your skills and the amount of time you can commit.
I suggest joining https://veraison.zulipchat.com so we can have a one-on-one chat there.
Signed-off-by: Priyanshu Thapliyal <[email protected]>
|
Hi @thomas-fossati i have rebase my branch on top of main |
Updated the Ubuntu setup instructions to include the installation of the docker-buildx plugin, which is necessary for building multi-platform Docker images.
Fixes #284