Turbopack build: Fix favicon-short-circuit (#70617) · vercel/next.js@0b7f7d5

Commit

Turbopack build: Fix favicon-short-circuit (#70617)

This test relied on `layout.js` being automatically written but that
isn't the case with Turbopack (as documented). Fixed the test by adding
the file that was magically generated.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

timneutkens authored Sep 30, 2024

1 parent 7fddec2 commit 0b7f7d5

test/e2e/favicon-short-circuit/app/layout.js

-Original file line number
+Diff line change
@@ -0,0 +1,7 @@
+    export default function RootLayout({ children }) {
+      return (
+        <html>
+          <body>{children}</body>
+        </html>
+      )
+    }

test/turbopack-build-tests-manifest.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -4732,10 +4732,10 @@ @@
           "runtimeError": false
         },
         "test/e2e/favicon-short-circuit/favicon-short-circuit.test.ts": {
-          "passed": [],
-          "failed": [
+          "passed": [
             "favicon-short-circuit should not short circuit the favicon in production"
           ],
+          "failed": [],
           "pending": [],
           "flakey": [],
           "runtimeError": false
@@ Expand Down @@

Please sign in to comment.