Skip to content

Commit

Permalink
Merge branch 'canary' into sam/github-workflow/bankrupt
Browse files Browse the repository at this point in the history
  • Loading branch information
samcx authored Jun 11, 2024
2 parents cbb6eda + e167e7f commit 7b97c09
Show file tree
Hide file tree
Showing 15 changed files with 54 additions and 50 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

env:
NAPI_CLI_VERSION: 2.16.2
TURBO_VERSION: 1.13.3-canary.2
TURBO_VERSION: 2.0.3
NODE_LTS_VERSION: 20
CARGO_PROFILE_RELEASE_LTO: 'true'
TURBO_TEAM: 'vercel'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.13.3-canary.2
TURBO_VERSION: 2.0.3
NODE_MAINTENANCE_VERSION: 18
NODE_LTS_VERSION: 20
TEST_CONCURRENCY: 8
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ on:

env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.13.3-canary.2
TURBO_VERSION: 2.0.3
NODE_LTS_VERSION: 20.9.0
TEST_CONCURRENCY: 8
# disable backtrace for test snapshots
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code_freeze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ name: Code Freeze

env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.13.3-canary.2
TURBO_VERSION: 2.0.3
NODE_LTS_VERSION: 20

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request_stats.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name: Generate Pull Request Stats

env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.13.3-canary.2
TURBO_VERSION: 2.0.3
NODE_LTS_VERSION: 20
TEST_CONCURRENCY: 6

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ name: Trigger Release

env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 1.13.3-canary.2
TURBO_VERSION: 2.0.3
NODE_LTS_VERSION: 20

jobs:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@
"taskr": "1.1.0",
"tree-kill": "1.2.2",
"tsec": "0.2.1",
"turbo": "1.13.3-canary.2",
"turbo": "2.0.3",
"typescript": "5.3.3",
"unfetch": "4.2.0",
"wait-port": "0.2.2",
Expand Down
6 changes: 4 additions & 2 deletions packages/create-next-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
"validate-npm-package-name": "5.0.1"
},
"engines": {
"node": ">=18.17.0"
}
"node": ">=18.17.0",
"pnpm": "8.15.7"
},
"packageManager": "[email protected]"
}
2 changes: 1 addition & 1 deletion packages/next-swc/turbo.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"extends": ["//"],
"pipeline": {
"tasks": {
"build-native": {
"inputs": [
"../../.cargo/**",
Expand Down
6 changes: 4 additions & 2 deletions packages/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,8 @@
"vercel"
],
"engines": {
"node": ">=18.17.0"
}
"node": ">=18.17.0",
"pnpm": "8.15.7"
},
"packageManager": "[email protected]"
}
46 changes: 23 additions & 23 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions scripts/normalize-version-bump.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,6 @@ const writeJson = async (filePath, data) =>
private: true,
workspaces: ['packages/*'],
scripts: {},
packageManager: '[email protected]',
})
})()
1 change: 0 additions & 1 deletion test/deploy-tests-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"test/production/**/*.test.{t,j}s{,x}"
],
"exclude": [
"test/e2e/app-dir/app-routes/app-custom-routes.test.ts",
"test/e2e/app-dir/next-after-app/index.test.ts",
"test/e2e/app-dir/scss/nm-module-nested/nm-module-nested.test.ts",
"test/e2e/cancel-request/stream-cancel.test.ts",
Expand Down
25 changes: 13 additions & 12 deletions test/e2e/app-dir/app-routes/app-custom-routes.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { nextTestSetup } from 'e2e-utils'
import { check, waitFor } from 'next-test-utils'
import { check, waitFor, retry } from 'next-test-utils'
import { Readable } from 'stream'

import {
Expand Down Expand Up @@ -679,18 +679,19 @@ describe('app-custom-routes', () => {
})
}

describe('no response returned', () => {
it('should print an error when no response is returned', async () => {
await next.fetch(basePath + '/no-response', { method: 'POST' })

await check(() => {
expect(next.cliOutput).toMatch(
/No response is returned from route handler '.+\/route\.ts'\. Ensure you return a `Response` or a `NextResponse` in all branches of your handler\./
)
return 'yes'
}, 'yes')
// This test is skipped in deploy mode because `next.cliOutput` will only contain build-time logs.
if (!isNextDeploy) {
describe('no response returned', () => {
it('should print an error when no response is returned', async () => {
await next.fetch(basePath + '/no-response', { method: 'POST' })
await retry(() => {
expect(next.cliOutput).toMatch(
/No response is returned from route handler '.+\/route\.ts'\. Ensure you return a `Response` or a `NextResponse` in all branches of your handler\./
)
})
})
})
})
}

describe('no bundle error', () => {
it('should not print bundling warning about React', async () => {
Expand Down
3 changes: 1 addition & 2 deletions turbo.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"$schema": "https://turborepo.org/schema.json",
"experimentalUI": true,
"pipeline": {
"tasks": {
"build": {
"dependsOn": ["^build"],
"outputs": ["dist/**"]
Expand Down

0 comments on commit 7b97c09

Please sign in to comment.