Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(turbopack-core): Use ResolvedVc in ContextCondition #74711

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 9, 2025

Closes PACK-3716

Copy link
Member Author

bgw commented Jan 9, 2025

@ijjk
Copy link
Member

ijjk commented Jan 9, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
buildDuration 20.8s 18.7s N/A
buildDurationCached 17.9s 15.2s N/A
nodeModulesSize 417 MB 417 MB
nextStartRea..uration (ms) 515ms 519ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
index.html gzip 524 B 524 B
link.html gzip 538 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
middleware-b..fest.js gzip 671 B 670 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 369 kB 369 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 357 kB 357 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.46 MB 2.46 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/resolved-context-condition Change
0.pack gzip 2.09 MB 2.09 MB ⚠️ +2.6 kB
index.pack gzip 75.6 kB 74.8 kB N/A
Overall change 2.09 MB 2.09 MB ⚠️ +2.6 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 6c75b21

@bgw bgw force-pushed the bgw/resolved-visited-client-reference-node branch from e6810f7 to e0d0daa Compare January 10, 2025 21:19
@bgw bgw force-pushed the bgw/resolved-context-condition branch from 6987329 to 9d0f736 Compare January 10, 2025 21:19
@bgw bgw force-pushed the bgw/resolved-visited-client-reference-node branch from e0d0daa to 6415648 Compare January 10, 2025 22:44
@bgw bgw force-pushed the bgw/resolved-context-condition branch from 9d0f736 to cd68d97 Compare January 10, 2025 22:45
@bgw bgw force-pushed the bgw/resolved-visited-client-reference-node branch from 6415648 to d592671 Compare January 10, 2025 23:10
@bgw bgw force-pushed the bgw/resolved-context-condition branch from cd68d97 to 6e19e4a Compare January 10, 2025 23:10
@bgw bgw force-pushed the bgw/resolved-visited-client-reference-node branch from d592671 to a83263c Compare January 11, 2025 00:29
@bgw bgw force-pushed the bgw/resolved-context-condition branch from 2239acc to 6c97345 Compare January 11, 2025 00:30
@bgw bgw force-pushed the bgw/resolved-visited-client-reference-node branch from a83263c to d52dda1 Compare January 11, 2025 01:36
@bgw bgw force-pushed the bgw/resolved-context-condition branch from 6c97345 to 64375e9 Compare January 11, 2025 01:37
@bgw bgw force-pushed the bgw/resolved-visited-client-reference-node branch from d52dda1 to 9bcf753 Compare January 11, 2025 02:07
@bgw bgw force-pushed the bgw/resolved-context-condition branch from 64375e9 to 40c717c Compare January 11, 2025 02:08
@bgw bgw force-pushed the bgw/resolved-visited-client-reference-node branch from 9bcf753 to a924d65 Compare January 13, 2025 16:23
@bgw bgw force-pushed the bgw/resolved-context-condition branch from 40c717c to e1cedc8 Compare January 13, 2025 16:26
@bgw bgw force-pushed the bgw/resolved-visited-client-reference-node branch 2 times, most recently from dc93225 to d51b928 Compare January 13, 2025 18:04
@bgw bgw force-pushed the bgw/resolved-context-condition branch from e1cedc8 to 494539b Compare January 13, 2025 18:04
@bgw bgw changed the base branch from bgw/resolved-visited-client-reference-node to graphite-base/74711 January 13, 2025 19:09
@bgw bgw changed the base branch from graphite-base/74711 to canary January 13, 2025 19:10
@bgw bgw force-pushed the bgw/resolved-context-condition branch from 494539b to 2e5ebc7 Compare January 13, 2025 19:10
@bgw bgw force-pushed the bgw/resolved-context-condition branch from 2e5ebc7 to 6c75b21 Compare January 13, 2025 19:10
@ijjk
Copy link
Member

ijjk commented Jan 13, 2025

Tests Passed

@bgw bgw merged commit 521cdae into canary Jan 13, 2025
125 of 130 checks passed
Copy link
Member Author

bgw commented Jan 13, 2025

Merge activity

  • Jan 13, 3:28 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/resolved-context-condition branch January 13, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants