refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714

bgw · 2025-01-09T21:14:50Z

No description provided.

bgw · 2025-01-09T21:15:15Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

perf(turbo-tasks): Optionally schedule ResolveNative/ResolveTrait tasks as local tasks #69126
refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714 👈 (View in Graphite)
refactor(turbopack/next-api): Make VcArc use OperationVc #74479
refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 3/3) #74173
refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 2/3) #74168
refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value (!!!) #74713
refactor(turbopack/next-core): Use ResolvedVc in PackagesGlobs #74712
refactor(turbopack-core): Use ResolvedVc in ContextCondition #74711
refactor(turbopack/next-core): Use ResolvedVc in VisitClientReferenceNodeState #74710
refactor(turbopack-ecmascript): Use ResolvedVc in CodeGen type #74709
refactor(turbopack-dev-server): Use ResolvedVc/NonLocalValue in RewriteType, remove all "local" opt-outs from structs #74708
refactor(turbopack-dev-server): Remove unresolved Vc from DevHtmlEntry, use a named struct #74707
refactor(turbopack-core): Remove remaining "local" value type opt-outs in turbopack-core #74706
chore(turbopack): Delete some dead code that was using unresolved Vcs #74705
refactor(turbopack/next-api): Implement NonLocalValue for TracedDiGraph and SingleModuleGraph #74506
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

bgw · 2025-01-09T21:24:43Z

turbopack/crates/turbo-tasks/src/task/function.rs

+        fn $get_args_fn<$($arg: TaskInput + 'static,)*>(arg: &dyn MagicAny) -> Result<($($arg,)*)> {
+            match arg.downcast_ref::<($($arg,)*)>() {
+                Some(($($arg,)*)) => Ok(($($arg.clone(),)*)),
+                None => {
+                    #[cfg(debug_assertions)]
+                    let context_str = get_debug_downcast_error_msg::<($($arg,)*)>(arg);
+                    #[cfg(not(debug_assertions))]
+                    let context_str = "Invalid argument type";
+
+                    anyhow::bail!(context_str);
+                }
+            }
+        }


Moved this inside the macro, which lets us deduplicate the .clone() calls, instead of putting them in each individual trait implementation.

bgw · 2025-01-09T21:27:13Z

turbopack/crates/turbo-tasks/src/task/function.rs

-        impl<F, Output, Recv, $($arg,)*> TaskFnInputFunctionWithThis<OperationMode, Recv, ($($arg,)*)> for F
-        where
-            Recv: Sync + Send + 'static,
-            $($arg: TaskInput + 'static,)*
-            F: Fn(OperationVc<Recv>, $($arg,)*) -> Output + Send + Sync + Clone + 'static,
-            Output: TaskOutput + 'static,
-        {
-            #[allow(non_snake_case)]
-            fn functor(&self, this: RawVc, arg: &dyn MagicAny) -> Result<NativeTaskFuture> {
-                let task_fn = self.clone();
-                let recv = OperationVc::<Recv>::from(this);
-
-                let ($($arg,)*) = get_args::<($($arg,)*)>(arg)?;
-                $(
-                    let $arg = $arg.clone();
-                )*
-
+                let ($($arg,)*) = $get_args_fn::<$($arg,)*>(arg)?;
                Ok(Box::pin(async move {
-                    Output::try_into_raw_vc((task_fn)(recv, $($arg,)*))
+                    let output = (task_fn)(recv, $($arg,)*);
+                    output_try_into_non_local_raw_vc(output).await
                }))
            }
        }


I ended up not implementing support for methods with #[turbo_tasks::function(operation)], given that there's a limited number of callsites, and dynamic dispatch likely couldn't work with methods taking self: OperationVc anyways.

ijjk · 2025-01-09T21:51:19Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
buildDuration	30.7s	25.2s	N/A
buildDurationCached	27.5s	24.4s	N/A
nodeModulesSize	417 MB	417 MB	✓
nextStartRea..uration (ms)	850ms	717ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
5306-HASH.js gzip	53.4 kB	53.4 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.44 kB	5.44 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.2 kB	34.2 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.57 kB	4.57 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
index.html gzip	524 B	523 B	N/A
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	520 B	520 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	207 kB	207 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
middleware-b..fest.js gzip	669 B	669 B	✓
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	1.51 kB	1.51 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	369 kB	369 kB	✓
app-page-exp..prod.js gzip	130 kB	130 kB	✓
app-page-tur..prod.js gzip	142 kB	142 kB	✓
app-page-tur..prod.js gzip	138 kB	138 kB	✓
app-page.run...dev.js gzip	357 kB	357 kB	✓
app-page.run..prod.js gzip	126 kB	126 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.7 kB	21.7 kB	✓
pages.runtim...dev.js gzip	27.5 kB	27.5 kB	✓
pages.runtim..prod.js gzip	21.7 kB	21.7 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.46 MB	2.46 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bgw/return-values-should-be-non-local	Change
0.pack gzip	2.09 MB	2.09 MB	⚠️ +563 B
index.pack gzip	74.8 kB	75.1 kB	⚠️ +347 B
Overall change	2.17 MB	2.17 MB	⚠️ +910 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 40117d9

sokra · 2025-01-10T14:51:48Z

turbopack/crates/turbo-tasks/src/task/function.rs

-fn get_args<T: MagicAny>(arg: &dyn MagicAny) -> Result<&T> {
-    let value = arg.downcast_ref::<T>();


I guess you could have archived the same with:

-fn get_args<T: MagicAny>(arg: &dyn MagicAny) -> Result<&T> { +fn get_args<T: MagicAny + Clone>(arg: &dyn MagicAny) -> Result<T> { - let value = arg.downcast_ref::<T>(); + let value = arg.downcast_ref::<T>().clone();

Since the tuple could be cloned

But not sure...

ijjk · 2025-01-10T21:37:22Z

Failing test suites

Commit: 40117d9

pnpm test-dev-turbo test/development/basic/next-rs-api.test.ts (turbopack)

next.rs api > should allow to write root page to disk
next.rs api > should allow to write pages edge api to disk
next.rs api > should allow to write pages Node.js api to disk
next.rs api > should allow to write app edge page to disk
next.rs api > should allow to write app Node.js page to disk
next.rs api > should allow to write pages edge page to disk
next.rs api > should allow to write pages Node.js page to disk
next.rs api > should allow to write app edge route to disk
next.rs api > should allow to write app Node.js route to disk

Expand output

● next.rs api › should allow to write root page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write root page to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  300 |       name: 'pages edge page',
  301 |       path: '/page-edge',
> 302 |       type: 'page',
      |                    ^
  303 |       runtime: 'edge',
  304 |       config: {},
  305 |     },

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:302:74)

● next.rs api › should allow to write root page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write root page to disk: data diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  305 |     },
  306 |     {
> 307 |       name: 'pages Node.js page',
      |                                  ^
  308 |       path: '/page-nodejs',
  309 |       type: 'page',
  310 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:307:75)

● next.rs api › should allow to write pages edge api to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write pages edge api to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  291 |     },
  292 |     {
> 293 |       name: 'app Node.js page',
      |                                ^
  294 |       path: '/app-nodejs',
  295 |       type: 'app-page',
  296 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:293:74)

● next.rs api › should allow to write pages Node.js api to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write pages Node.js api to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  291 |     },
  292 |     {
> 293 |       name: 'app Node.js page',
      |                                ^
  294 |       path: '/app-nodejs',
  295 |       type: 'app-page',
  296 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:293:74)

● next.rs api › should allow to write app edge page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write app edge page to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  314 |       name: 'app edge route',
  315 |       path: '/route-edge',
> 316 |       type: 'app-route',
      |                         ^
  317 |       runtime: 'edge',
  318 |       config: {},
  319 |     },

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:316:74)

● next.rs api › should allow to write app edge page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write app edge page to disk: rsc diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  319 |     },
  320 |     {
> 321 |       name: 'app Node.js route',
      |                                 ^
  322 |       path: '/route-nodejs',
  323 |       type: 'app-route',
  324 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:321:75)

● next.rs api › should allow to write app Node.js page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write app Node.js page to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  314 |       name: 'app edge route',
  315 |       path: '/route-edge',
> 316 |       type: 'app-route',
      |                         ^
  317 |       runtime: 'edge',
  318 |       config: {},
  319 |     },

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:316:74)

● next.rs api › should allow to write app Node.js page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write app Node.js page to disk: rsc diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  319 |     },
  320 |     {
> 321 |       name: 'app Node.js route',
      |                                 ^
  322 |       path: '/route-nodejs',
  323 |       type: 'app-route',
  324 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:321:75)

● next.rs api › should allow to write pages edge page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write pages edge page to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  300 |       name: 'pages edge page',
  301 |       path: '/page-edge',
> 302 |       type: 'page',
      |                    ^
  303 |       runtime: 'edge',
  304 |       config: {},
  305 |     },

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:302:74)

● next.rs api › should allow to write pages edge page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write pages edge page to disk: data diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  305 |     },
  306 |     {
> 307 |       name: 'pages Node.js page',
      |                                  ^
  308 |       path: '/page-nodejs',
  309 |       type: 'page',
  310 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:307:75)

● next.rs api › should allow to write pages Node.js page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write pages Node.js page to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  300 |       name: 'pages edge page',
  301 |       path: '/page-edge',
> 302 |       type: 'page',
      |                    ^
  303 |       runtime: 'edge',
  304 |       config: {},
  305 |     },

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:302:74)

● next.rs api › should allow to write pages Node.js page to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write pages Node.js page to disk: data diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  305 |     },
  306 |     {
> 307 |       name: 'pages Node.js page',
      |                                  ^
  308 |       path: '/page-nodejs',
  309 |       type: 'page',
  310 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:307:75)

● next.rs api › should allow to write app edge route to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write app edge route to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  291 |     },
  292 |     {
> 293 |       name: 'app Node.js page',
      |                                ^
  294 |       path: '/app-nodejs',
  295 |       type: 'app-page',
  296 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:293:74)

● next.rs api › should allow to write app Node.js route to disk

expect(received).toMatchSnapshot(hint)

Snapshot name: `next.rs api should allow to write app Node.js route to disk: diagnostics 1`

- Snapshot  -   1
+ Received  + 100

- []
+ [
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "modularizeImports": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "persistentCaching": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "platform-triplet": "true",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipMiddlewareUrlNormalize": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "skipTrailingSlashRedirect": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcEmotion": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcExperimentalDecorators": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcImportSource": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcReactRemoveProperties": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRelay": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcRemoveConsole": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "swcStyledComponents": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "transpilePackages": "false",
+     },
+   },
+   {
+     "category": "NextFeatureTelemetry_category_tbd",
+     "name": "EVENT_BUILD_FEATURE_USAGE",
+     "payload": {
+       "turbotrace": "false",
+     },
+   },
+ ]

  291 |     },
  292 |     {
> 293 |       name: 'app Node.js page',
      |                                ^
  294 |       path: '/app-nodejs',
  295 |       type: 'app-page',
  296 |       runtime: 'nodejs',

  at Object.<anonymous> (development/basic/next-rs-api.test.ts:293:74)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/persistent-caching/persistent-caching.test.ts (PPR)

persistent-caching > should persistent cache loaders

Expand output

● persistent-caching › should persistent cache loaders

expect(received).toBe(expected) // Object.is equality

Expected: "Timestamp = 1736825058942"
Received: "Timestamp = 1736825079077"

  55 |       const browser = await next.browser('/pages')
  56 |       // TODO Persistent Caching for webpack dev server is broken
> 57 |       expect(await browser.elementByCss('main').text()).toBe(pagesTimestamp)
     |                                                         ^
  58 |       await browser.close()
  59 |     }
  60 |   })

  at Object.toBe (e2e/persistent-caching/persistent-caching.test.ts:57:57)

Read more about building and testing Next.js in contributing.md.

…ing from task functions

ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 9, 2025

bgw mentioned this pull request Jan 9, 2025

refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value (!!!) #74713

Merged

bgw requested a review from sokra January 9, 2025 21:23

bgw marked this pull request as ready for review January 9, 2025 21:23

bgw commented Jan 9, 2025

View reviewed changes

sokra added the CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci label Jan 10, 2025 — with Graphite App

sokra reviewed Jan 10, 2025

View reviewed changes

sokra approved these changes Jan 10, 2025

View reviewed changes

bgw force-pushed the bgw/vcarc-uses-operationvc branch from d2c1eab to 56c77c9 Compare January 10, 2025 21:20

bgw force-pushed the bgw/return-values-should-be-non-local branch from 110001f to 1f21777 Compare January 10, 2025 21:20

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 56c77c9 to 3ca36f6 Compare January 10, 2025 22:48

bgw force-pushed the bgw/return-values-should-be-non-local branch from 1f21777 to 1a10536 Compare January 10, 2025 22:49

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 3ca36f6 to d930890 Compare January 10, 2025 23:11

bgw force-pushed the bgw/return-values-should-be-non-local branch from 1a10536 to 59ff3b4 Compare January 10, 2025 23:11

bgw force-pushed the bgw/vcarc-uses-operationvc branch from d930890 to fc3f3d2 Compare January 10, 2025 23:46

bgw force-pushed the bgw/return-values-should-be-non-local branch from 59ff3b4 to 1713534 Compare January 10, 2025 23:46

bgw force-pushed the bgw/vcarc-uses-operationvc branch from fc3f3d2 to 968aa54 Compare January 11, 2025 00:33

bgw force-pushed the bgw/return-values-should-be-non-local branch from 1713534 to 90c2d5c Compare January 11, 2025 00:34

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 968aa54 to 9585d5e Compare January 11, 2025 01:40

bgw force-pushed the bgw/return-values-should-be-non-local branch from 90c2d5c to fe63d1b Compare January 11, 2025 01:41

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 9585d5e to 2d433d3 Compare January 11, 2025 02:11

bgw force-pushed the bgw/return-values-should-be-non-local branch from fe63d1b to 0e91d34 Compare January 11, 2025 02:12

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 2d433d3 to ff5cce9 Compare January 13, 2025 16:46

bgw force-pushed the bgw/return-values-should-be-non-local branch from 0e91d34 to fb08b7c Compare January 13, 2025 16:49

bgw force-pushed the bgw/vcarc-uses-operationvc branch from ff5cce9 to 03c98a4 Compare January 13, 2025 18:07

bgw force-pushed the bgw/return-values-should-be-non-local branch from fb08b7c to c7279e4 Compare January 13, 2025 18:08

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 03c98a4 to f8efda7 Compare January 13, 2025 19:13

bgw force-pushed the bgw/return-values-should-be-non-local branch from c7279e4 to b2e9360 Compare January 13, 2025 19:13

bgw force-pushed the bgw/vcarc-uses-operationvc branch from f8efda7 to 9c94863 Compare January 13, 2025 20:31

bgw force-pushed the bgw/return-values-should-be-non-local branch from b2e9360 to 9c6d5d4 Compare January 13, 2025 20:32

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 9c94863 to 9b82562 Compare January 13, 2025 22:09

bgw force-pushed the bgw/return-values-should-be-non-local branch from 9c6d5d4 to 78f1579 Compare January 13, 2025 22:10

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 9b82562 to 006a836 Compare January 13, 2025 22:50

bgw force-pushed the bgw/return-values-should-be-non-local branch from 78f1579 to 073dfc1 Compare January 13, 2025 22:51

bgw force-pushed the bgw/vcarc-uses-operationvc branch from 006a836 to d580123 Compare January 14, 2025 02:07

bgw force-pushed the bgw/return-values-should-be-non-local branch from 073dfc1 to 6ed1846 Compare January 14, 2025 02:08

bgw force-pushed the bgw/vcarc-uses-operationvc branch 2 times, most recently from 8ca6dfa to f6ab4a3 Compare January 14, 2025 03:02

refactor(turbo-tasks): Convert local Vcs to non-local Vcs when return…

40117d9

…ing from task functions

bgw force-pushed the bgw/return-values-should-be-non-local branch from 6ed1846 to 40117d9 Compare January 14, 2025 03:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714

refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714

bgw commented Jan 9, 2025

bgw commented Jan 9, 2025 •

edited

Loading

bgw Jan 9, 2025

bgw Jan 9, 2025

ijjk commented Jan 9, 2025 •

edited

Loading

sokra Jan 10, 2025 •

edited

Loading

ijjk commented Jan 10, 2025 •

edited

Loading

		fn get_args<T: MagicAny>(arg: &dyn MagicAny) -> Result<&T> {
		let value = arg.downcast_ref::<T>();

refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714

Are you sure you want to change the base?

refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714

Conversation

bgw commented Jan 9, 2025

bgw commented Jan 9, 2025 • edited Loading

bgw Jan 9, 2025

Choose a reason for hiding this comment

bgw Jan 9, 2025

Choose a reason for hiding this comment

ijjk commented Jan 9, 2025 • edited Loading

Stats from current PR

sokra Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

ijjk commented Jan 10, 2025 • edited Loading

Failing test suites

bgw commented Jan 9, 2025 •

edited

Loading

ijjk commented Jan 9, 2025 •

edited

Loading

sokra Jan 10, 2025 •

edited

Loading

ijjk commented Jan 10, 2025 •

edited

Loading