-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cms agilitycms #27378
Update cms agilitycms #27378
Conversation
<Link href={`/blog/${featuredPost.fields.slug}`}> | ||
<a className="cursor-pointer"> | ||
<div className="h-64 sm:h-96 relative"> | ||
<AgilityImage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any insight why Agility image over next/image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leerob AgilityImage actually uses next/image behind the scenes! It avoids the need for any other config as it just changes the image URL parameters to resize it or change format and quality on our CDN
return dynamicUrls; | ||
}; | ||
|
||
PostsListing.getCustomInitialProps = async ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leerob getCustomInitialProps fetches additional data from Agility during the build process
|
||
export default async (req, res) => { | ||
|
||
//TODO: Only generate the preview link if you are already in Preview! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO, also formatting 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created an issue so we have this todo tracked: agility/agilitycms-nextjs-starter#24
|
||
let previewUrl = req.query.slug; | ||
|
||
//TODO: these kinds of dynamic links should work by default (even outside of preview) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created an issue so we have this todo tracked: agility/agilitycms-nextjs-starter#25
lineHeight: { | ||
tight: 1.2, | ||
teal: { | ||
100: "#e6fffa", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just use the default color palette from Tailwind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I could just extend the default tailwind color palette instead of creating a new one, thanks!
@joshua-isaac this PR has some merge conflicts and given it has been opened for a while, I'm closing it. If you would like to address the conflicts, feel free to reopen, otherwise, someone else might want to take a look! Thanks! 🙏 💚 |
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples