-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bash script to run a benchmark #64717
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
#!/bin/bash | ||
|
||
# run a benchmark against this binary | ||
# using heaptrack to extract memory | ||
# usage numbers at g-max | ||
|
||
set -e | ||
|
||
COMMIT=${1:-13d9693808badd4b92811abac5e18dc1cddf2384} # the sha of the commit to benchmark | ||
PAGES=${2:-"/sink,/examples/forms/appearance,/examples/cards,/examples/dashboard,/api/components,/examples/forms/notifications,/sink/new-york,/examples/forms/display,/blocks,/docs/[[...slug]]"} # the list of pages to build | ||
|
||
SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )" | ||
|
||
# build the binary | ||
cargo build --profile release-with-debug --manifest-path "$SCRIPTPATH/Cargo.toml" | ||
|
||
# create a temp dir and clone shadcn-ui into it | ||
TMPDIR=$(mktemp -d) | ||
git clone https://github.com/shadcn-ui/ui.git "$TMPDIR" | ||
cd "$TMPDIR/apps/www" | ||
git checkout "$COMMIT" | ||
|
||
# install the dependencies and change dir | ||
pnpm install | ||
|
||
# heaptrack the binary with the project options in raw mode | ||
heaptrack --record-only "$SCRIPTPATH/../../../../target/release-with-debug/next-build-test" concurrent 12 "$PAGES" | ||
"$SCRIPTPATH/../../../../target/release-with-debug/next-build-test" run concurrent 12 999 "$PAGES" | ||
|
||
# get most recently created heaptrack profile and run it via heaptrack_print | ||
PROFILE=$(ls -t "$TMPDIR/heaptrack.*" | head -n1) | ||
heaptrack_print "$PROFILE" > "$SCRIPTPATH/result.log" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of heaptrack you could print out
TurboMalloc::memory_usage()
which is our own counter of memory usage. That probably makes it a bit fasterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah TBH heaptrack was useful but in this case the overhead will probably be quite brutal when running on CI