Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use react-dom/server.edge instead of .browser in Next.js runtime #66954

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Use react-dom/server.edge instead of .browser in Next.js runtime #66954

merged 3 commits into from
Jun 19, 2024

Commits on Jun 17, 2024

  1. Use react-dom/server.edge instead of .browser in Edge Runtime

    @eps1lon
    eps1lon committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    12cc42f View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Import .edge instead

    @eps1lon
    eps1lon committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    810c529 View commit details
    Browse the repository at this point in the history

  2. Use next-swc from branch for PR size stats (#66964) 

    Currently, PR stats are always downloading published binaries:

> cd /tmp/next-statsJoJEbE/stats-app && NEXT_TELEMETRY_DISABLED=1 pnpm
next build
> [...]
> Downloading swc package @next/swc-linux-x64-gnu...

--
https://github.com/vercel/next.js/actions/runs/9505097022/job/26199227309#step:7:1713

## test plan
- [x] Makes #66711 go green
- [x] `GIT_ROOT_DIR=https://github.com/ GITHUB_REPOSITORY=vercel/next.js
GITHUB_REF=sebbie/06-10-update_react_from_1df34bdf62_to_20b6f4c0e8
GITHUB_ACTION=synchronize node
.github/actions/next-stats-action/src/index.js` completes `pnpm build`
(but fails afterwards locally which is expected)
    @eps1lon
    eps1lon authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    797bb8c View commit details
    Browse the repository at this point in the history