-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Yarn/npm specific fields in root package.json #68186
Merged
eps1lon
merged 1 commit into
canary
from
sebbie/07-26-cleanup_yarn/npm_specific_fields_in_root_package.json
Jul 29, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,9 +2,6 @@ | |
"name": "nextjs-project", | ||
"version": "0.0.0", | ||
"private": true, | ||
"workspaces": [ | ||
"packages/*" | ||
], | ||
"scripts": { | ||
"new-error": "turbo gen error", | ||
"new-test": "turbo gen test", | ||
|
@@ -246,28 +243,28 @@ | |
"ws": "8.2.3", | ||
"yargs": "16.2.0" | ||
}, | ||
"resolutions": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While pnpm does respect this field, it's confusing since it's not how you'd look up docs for this field in pnpm. Moved to |
||
"webpack": "5.90.0", | ||
"browserslist": "4.22.2", | ||
"caniuse-lite": "1.0.30001579", | ||
"@types/node": "20.12.3", | ||
"@babel/core": "7.22.5", | ||
"@babel/parser": "7.22.5", | ||
"@babel/types": "7.22.5", | ||
"@babel/traverse": "7.22.5", | ||
"@types/react": "npm:[email protected]", | ||
"@types/react-dom": "npm:[email protected]", | ||
"react": "19.0.0-rc-76002254-20240724", | ||
"react-dom": "19.0.0-rc-76002254-20240724", | ||
"react-is": "19.0.0-rc-76002254-20240724", | ||
"scheduler": "0.25.0-rc-76002254-20240724" | ||
}, | ||
"engines": { | ||
"node": ">=18.18.0", | ||
"pnpm": "9.6.0" | ||
}, | ||
"packageManager": "[email protected]", | ||
"pnpm": { | ||
"overrides": { | ||
"webpack": "5.90.0", | ||
"browserslist": "4.22.2", | ||
"caniuse-lite": "1.0.30001579", | ||
"@types/node": "20.12.3", | ||
"@babel/core": "7.22.5", | ||
"@babel/parser": "7.22.5", | ||
"@babel/types": "7.22.5", | ||
"@babel/traverse": "7.22.5", | ||
"@types/react": "npm:[email protected]", | ||
"@types/react-dom": "npm:[email protected]", | ||
"react": "19.0.0-rc-76002254-20240724", | ||
"react-dom": "19.0.0-rc-76002254-20240724", | ||
"react-is": "19.0.0-rc-76002254-20240724", | ||
"scheduler": "0.25.0-rc-76002254-20240724" | ||
}, | ||
"patchedDependencies": { | ||
"[email protected]": "patches/[email protected]" | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This no longer matches the pnpm-workspaces file. Preferring the pnpm specific file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to revert in #68186 since Lerna still uses those for some reason.