Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Yarn/npm specific fields in root package.json #68186

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
"name": "nextjs-project",
"version": "0.0.0",
"private": true,
"workspaces": [
"packages/*"
],
Comment on lines -5 to -7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This no longer matches the pnpm-workspaces file. Preferring the pnpm specific file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to revert in #68186 since Lerna still uses those for some reason.

"scripts": {
"new-error": "turbo gen error",
"new-test": "turbo gen test",
Expand Down Expand Up @@ -246,28 +243,28 @@
"ws": "8.2.3",
"yargs": "16.2.0"
},
"resolutions": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While pnpm does respect this field, it's confusing since it's not how you'd look up docs for this field in pnpm. Moved to pnpm.overrides

"webpack": "5.90.0",
"browserslist": "4.22.2",
"caniuse-lite": "1.0.30001579",
"@types/node": "20.12.3",
"@babel/core": "7.22.5",
"@babel/parser": "7.22.5",
"@babel/types": "7.22.5",
"@babel/traverse": "7.22.5",
"@types/react": "npm:[email protected]",
"@types/react-dom": "npm:[email protected]",
"react": "19.0.0-rc-76002254-20240724",
"react-dom": "19.0.0-rc-76002254-20240724",
"react-is": "19.0.0-rc-76002254-20240724",
"scheduler": "0.25.0-rc-76002254-20240724"
},
"engines": {
"node": ">=18.18.0",
"pnpm": "9.6.0"
},
"packageManager": "[email protected]",
"pnpm": {
"overrides": {
"webpack": "5.90.0",
"browserslist": "4.22.2",
"caniuse-lite": "1.0.30001579",
"@types/node": "20.12.3",
"@babel/core": "7.22.5",
"@babel/parser": "7.22.5",
"@babel/types": "7.22.5",
"@babel/traverse": "7.22.5",
"@types/react": "npm:[email protected]",
"@types/react-dom": "npm:[email protected]",
"react": "19.0.0-rc-76002254-20240724",
"react-dom": "19.0.0-rc-76002254-20240724",
"react-is": "19.0.0-rc-76002254-20240724",
"scheduler": "0.25.0-rc-76002254-20240724"
},
"patchedDependencies": {
"[email protected]": "patches/[email protected]"
}
Expand Down
Loading