Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: RC Updates #70031

Merged
merged 75 commits into from
Oct 14, 2024
Merged

Docs: RC Updates #70031

merged 75 commits into from
Oct 14, 2024

Conversation

delbaoliveira
Copy link
Contributor

@delbaoliveira delbaoliveira commented Sep 12, 2024

Do not merge.

Closes: https://linear.app/vercel/issue/DOC-3018/nextjs-15-rc-2

@ijjk ijjk added created-by: Next.js DevEx team Documentation Related to Next.js' official documentation. labels Sep 12, 2024
Copy link
Contributor

github-actions bot commented Sep 12, 2024

All broken links are now fixed, thank you!

Copy link
Collaborator

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Left some comments

ztanner added a commit that referenced this pull request Oct 9, 2024
- Lifts the migration guide from #70031
- Adds additional details & updates with the latest information
kdy1 pushed a commit that referenced this pull request Oct 10, 2024
- Lifts the migration guide from #70031
- Adds additional details & updates with the latest information
kdy1 pushed a commit that referenced this pull request Oct 10, 2024
- Lifts the migration guide from #70031
- Adds additional details & updates with the latest information
delbaoliveira and others added 20 commits October 14, 2024 07:59
- No examples for pages docs for now, we need to spend more time understanding the patterns there. RC is shipping today.
@delbaoliveira delbaoliveira marked this pull request as ready for review October 14, 2024 10:27
@delbaoliveira delbaoliveira merged commit 2f6054f into canary Oct 14, 2024
50 checks passed
@delbaoliveira delbaoliveira deleted the docs-rc-updates branch October 14, 2024 10:41
@tresorama
Copy link

tresorama commented Oct 15, 2024

Please include in this page that :
If user-land uses draft mode with an Headless CMS (Directus...) that sends the request to draft mode with an <iframe>, the default cookie set by draftMode().enable() has SameSite=lax and this means that the iframe cannot use that cookie, resulting in draftmode considered disabled by Next.

The solution is that user-land rewrites the cookie, overwriting SameSite=lax with SameSite=none; Secure=true.

Like in #49927


What I said is true for Next 14.2.15 and Directus, don't know if it's still true with Next 15.
I suggest to include this:

  • because the common usage for draft mode is in combination with an Headless CMS, and they use an iframe 90% of the time.
  • I expect the docs (that are great) to tell me about that
  • i saw you updated this page yesterday so maybe it's the ideal moment

Thanks 😎

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js DevEx team Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants