Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace depricated apple-mobile-web-app-capable with `mobile-web-ap… #70363

Merged
merged 14 commits into from
Oct 1, 2024
Merged

Replace depricated apple-mobile-web-app-capable with `mobile-web-ap… #70363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8ebd1ec
Replace depricated `apple-mobile-web-app-capable` with `mobile-web-ap…
Nayeem-XTREME Sep 23, 2024
d1e5f50
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 24, 2024
451433a
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 24, 2024
519d366
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 25, 2024
79a1ddd
Update packages/next/src/lib/metadata/types/metadata-types.ts
Nayeem-XTREME Sep 25, 2024
1707d21
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 25, 2024
a5ef5fb
Merge branch 'canary' into replace-depricated-meta-tag
huozhi Sep 25, 2024
0eaa3ba
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 25, 2024
a085e77
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 26, 2024
b64dca3
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 26, 2024
95c588a
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 27, 2024
fdfce08
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Sep 29, 2024
b4dba4b
Merge branch 'canary' into replace-depricated-meta-tag
Nayeem-XTREME Oct 1, 2024
43ac429
fix lint
huozhi Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/02-app/02-api-reference/04-functions/generate-metadata.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ export const metadata = {
name="apple-itunes-app"
content="app-id=myAppStoreID, app-argument=myAppArgument"
/>
<meta name="apple-mobile-web-app-capable" content="yes" />
<meta name="mobile-web-app-capable" content="yes" />
<meta name="apple-mobile-web-app-title" content="Apple Web App" />
<link
href="/assets/startup/apple-touch-startup-image-768x1004.png"
Expand Down
4 changes: 1 addition & 3 deletions packages/next/src/lib/metadata/generate/basic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,7 @@ export function AppleWebAppMeta({
const { capable, title, startupImage, statusBarStyle } = appleWebApp

return MetaFilter([
capable
? Meta({ name: 'apple-mobile-web-app-capable', content: 'yes' })
: null,
capable ? Meta({ name: 'mobile-web-app-capable', content: 'yes' }) : null,
Meta({ name: 'apple-mobile-web-app-title', content: title }),
startupImage
? startupImage.map((image) => (
Expand Down
2 changes: 1 addition & 1 deletion packages/next/src/lib/metadata/types/metadata-interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ interface Metadata extends DeprecatedMetadataFields {
* @example
* ```tsx
* { capable: true, title: "My Website", statusBarStyle: "black-translucent" }
* <meta name="apple-mobile-web-app-capable" content="yes" />
* <meta name="mobile-web-app-capable" content="yes" />
* <meta name="apple-mobile-web-app-title" content="My Website" />
* <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent" />
* ```
Expand Down
3 changes: 1 addition & 2 deletions packages/next/src/lib/metadata/types/metadata-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
export interface DeprecatedMetadataFields {
/**
* Deprecated options that have a preferred method
* @deprecated Use appWebApp to configure apple-mobile-web-app-capable which provides
* @see https://www.appsloveworld.com/coding/iphone/11/difference-between-apple-mobile-web-app-capable-and-apple-touch-fullscreen-ipho
* @deprecated Use appWebApp to configure mobile-web-app-capable which provides
*/
'apple-touch-fullscreen'?: never

Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/metadata/metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ describe('app dir - metadata', () => {

await matchMultiDom('meta', 'name', 'content', {
'apple-itunes-app': 'app-id=myAppStoreID, app-argument=myAppArgument',
'apple-mobile-web-app-capable': 'yes',
'mobile-web-app-capable': 'yes',
'apple-mobile-web-app-title': 'Apple Web App',
'apple-mobile-web-app-status-bar-style': 'black-translucent',
})
Expand Down
Loading