Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-next-app: default to ESLint disabled #73864

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

leerob
Copy link
Member

@leerob leerob commented Dec 12, 2024

You can optionally enable it, if desired, but this gives you one less config file by default.

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js DevEx team PRs by the DX team. labels Dec 12, 2024
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js disable-eslint-cna Change
buildDuration 25s 22s N/A
buildDurationCached 21.3s 17.9s N/A
nodeModulesSize 417 MB 417 MB
nextStartRea..uration (ms) 564ms 569ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js disable-eslint-cna Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js disable-eslint-cna Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js disable-eslint-cna Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js disable-eslint-cna Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js disable-eslint-cna Change
index.html gzip 523 B 523 B
link.html gzip 538 B 535 B N/A
withRouter.html gzip 519 B 519 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js disable-eslint-cna Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js disable-eslint-cna Change
middleware-b..fest.js gzip 666 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js disable-eslint-cna Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 363 kB 363 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 352 kB 352 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.45 MB 2.45 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js disable-eslint-cna Change
0.pack gzip 2.08 MB 2.09 MB ⚠️ +4.03 kB
index.pack gzip 74.4 kB 74.8 kB ⚠️ +419 B
Overall change 2.16 MB 2.16 MB ⚠️ +4.44 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 6bfdc88

@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

looks like we need to update our prompt tests for this change

Copy link
Contributor

@feedthejim feedthejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holding until we further discuss this decision

@ijjk ijjk added the tests label Jan 6, 2025
@ztanner ztanner merged commit 3c44559 into canary Jan 28, 2025
129 checks passed
@ztanner ztanner deleted the disable-eslint-cna branch January 28, 2025 21:33
@hichemfantar
Copy link
Contributor

I don't know about this. we should be encouraging people to write safer and better code.

@r34son
Copy link
Contributor

r34son commented Jan 29, 2025

@leerob Could you please give more details whats motivation for this change?

@leerob
Copy link
Member Author

leerob commented Jan 29, 2025

ESLint is still part of create-next-app. If you would like to continue using it, please do! We are also working on adding support for Biome, and at that point, you will have the option to pick the tool you prefer.

x-ref: #73905

@hichemfantar
Copy link
Contributor

56% of 144 people is such a small sample size to be making such a decision and it's only been a month.

@leerob Would you reconsider if the vote swings another way in the near future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js DevEx team PRs by the DX team. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants