Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[not for merge] Flush out faulty scroll behavior #74755

Draft
wants to merge 3 commits into
base: canary
Choose a base branch
from

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 10, 2025

No description provided.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 10, 2025
Copy link
Member Author

eps1lon commented Jan 10, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 10, 2025

Failing test suites

Commit: f6c8578

pnpm test-dev test/development/replayed-internal-errors/index.test.ts

  • Replaying internal errors > should not log the internal error thrown by notFound()
Expand output

● Replaying internal errors › should not log the internal error thrown by notFound()

expect(received).toBe(expected) // Object.is equality

Expected: "Not found"
Received: "Console Error"

  49 |     await browser.elementByCss('a[href="/will-notfound"]').click()
  50 |     await retry(async () => {
> 51 |       expect(await browser.elementByCss('h1').text()).toBe('Not found')
     |                                                       ^
  52 |     })
  53 |
  54 |     expect(next.cliOutput).toContain(EXPECTED_REPLAYED_MESSAGE)

  at toBe (development/replayed-internal-errors/index.test.ts:51:55)
  at retry (lib/next-test-utils.ts:806:14)
  at Object.<anonymous> (development/replayed-internal-errors/index.test.ts:50:5)

Read more about building and testing Next.js in contributing.md.

pnpm test-start-turbo test/e2e/app-dir/navigation-layout-suspense/navigation-layout-suspense.test.ts (turbopack)

  • app dir - navigation with Suspense in nested layout > resolves data after client navigation to a nested layout with Suspense
Expand output

● app dir - navigation with Suspense in nested layout › resolves data after client navigation to a nested layout with Suspense

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-testid="nested-resolved"]')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/navigation-layout-suspense/navigation-layout-suspense.test.ts:17:19)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/error-boundary-navigation/index.test.ts

  • app dir - not found navigation > should allow navigating to a page calling notfound
  • app dir - not found navigation > should be able to navigate to other page from root not-found page
Expand output

● app dir - not found navigation › should allow navigating to a page calling notfound

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#not-found-component')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at Object.<anonymous> (e2e/app-dir/error-boundary-navigation/index.test.ts:68:5)
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/error-boundary-navigation/index.test.ts:71:8)

● app dir - not found navigation › should be able to navigate to other page from root not-found page

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#not-found-component')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at Object.<anonymous> (e2e/app-dir/error-boundary-navigation/index.test.ts:116:5)
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/error-boundary-navigation/index.test.ts:119:8)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-start test/e2e/app-dir/not-found-default/index.test.ts (PPR)

  • app dir - not found with default 404 page > should be able to navigate to page calling not-found
  • app dir - not found with default 404 page > should be able to navigate to page with calling not-found in metadata
Expand output

● app dir - not found with default 404 page › should be able to navigate to page calling not-found

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('.next-error-h1')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/not-found-default/index.test.ts:60:19)

● app dir - not found with default 404 page › should be able to navigate to page with calling not-found in metadata

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('.next-error-h1')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/not-found-default/index.test.ts:72:19)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-start test/e2e/app-dir/forbidden/default/forbidden-default.test.ts (PPR)

  • app dir - forbidden with default forbidden boundary > should be able to navigate to page calling forbidden
  • app dir - forbidden with default forbidden boundary > should be able to navigate to page with calling forbidden in metadata
Expand output

● app dir - forbidden with default forbidden boundary › should be able to navigate to page calling forbidden

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('.next-error-h1')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/forbidden/default/forbidden-default.test.ts:48:19)

● app dir - forbidden with default forbidden boundary › should be able to navigate to page with calling forbidden in metadata

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('.next-error-h1')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/forbidden/default/forbidden-default.test.ts:60:19)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/unauthorized/default/unauthorized-default.test.ts (PPR)

  • app dir - unauthorized with default unauthorized boundary > should be able to navigate to page calling unauthorized
  • app dir - unauthorized with default unauthorized boundary > should be able to navigate to page with calling unauthorized in metadata
Expand output

● app dir - unauthorized with default unauthorized boundary › should be able to navigate to page calling unauthorized

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('.next-error-h1')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/unauthorized/default/unauthorized-default.test.ts:48:19)

● app dir - unauthorized with default unauthorized boundary › should be able to navigate to page with calling unauthorized in metadata

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('.next-error-h1')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as waitForElementByCss] (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/unauthorized/default/unauthorized-default.test.ts:60:19)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/error-boundary-navigation/override-node-env.test.ts (PPR)

  • app dir - not found navigation > should allow navigating to a page calling notfound
  • app dir - not found navigation > should be able to navigate to other page from root not-found page
  • app dir - not found navigation - with overridden node env > should allow navigating to a page calling notfound
Expand output

● app dir - not found navigation › should allow navigating to a page calling notfound

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#not-found-component')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at Object.<anonymous> (e2e/app-dir/error-boundary-navigation/index.test.ts:68:5)
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/error-boundary-navigation/index.test.ts:71:8)

● app dir - not found navigation › should be able to navigate to other page from root not-found page

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#not-found-component')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at Object.<anonymous> (e2e/app-dir/error-boundary-navigation/index.test.ts:116:5)
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/error-boundary-navigation/index.test.ts:119:8)

● app dir - not found navigation - with overridden node env › should allow navigating to a page calling notfound

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#not-found-component')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at Object.<anonymous> (e2e/app-dir/error-boundary-navigation/index.test.ts:68:5)
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:423:17)
  at Object.waitForElementByCss (e2e/app-dir/error-boundary-navigation/index.test.ts:71:8)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts

  • segment cache (basic tests) > skips static layouts during partially static navigation
Expand output

● segment cache (basic tests) › skips static layouts during partially static navigation

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  199 |   })
  200 |
> 201 |   it('skips static layouts during partially static navigation', async () => {
      |   ^
  202 |     let act: ReturnType<typeof createRouterAct>
  203 |     const browser = await next.browser('/partially-static', {
  204 |       beforePageLoad(page: Playwright.Page) {

  at it (e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts:201:3)
  at Object.describe (e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts:5:1)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/actions/app-action.test.ts (PPR)

  • app-dir action handling > should forward action request to a worker that contains the action handler (node)
  • app-dir action handling > should forward action request to a worker that contains the action handler (edge)
  • app-dir action handling > should work with interception routes
  • app-dir action handling > fetch actions > should handle redirects to routes that provide an invalid RSC response
Expand output

● app-dir action handling › should forward action request to a worker that contains the action handler (node)

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#other-page')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at e2e/app-dir/actions/app-action.test.ts:862:7
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:423:17)
  at waitForElementByCss (e2e/app-dir/actions/app-action.test.ts:865:10)

● app-dir action handling › should forward action request to a worker that contains the action handler (edge)

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#other-page')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at e2e/app-dir/actions/app-action.test.ts:862:7
  at Proxy.chain (lib/browsers/base.ts:17:23)
  at Proxy.chain (lib/browsers/playwright.ts:423:17)
  at waitForElementByCss (e2e/app-dir/actions/app-action.test.ts:865:10)

● app-dir action handling › fetch actions › should handle redirects to routes that provide an invalid RSC response

expect(received).toContain(expected) // indexOf

Expected substring: "Hello from a pages route"
Received string:    "0.8384694852924586
Client
Server
Client and Server
0
+1+1 (Slow)-1*2
redirect to a pages route
submit
test"

  1269 |
  1270 |       await retry(async () => {
> 1271 |         expect(await browser.elementByCss('body').text()).toContain(
       |                                                           ^
  1272 |           'Hello from a pages route'
  1273 |         )
  1274 |         expect(await browser.url()).toBe(`${next.url}/pages-dir`)

  at toContain (e2e/app-dir/actions/app-action.test.ts:1271:59)
  at retry (lib/next-test-utils.ts:806:14)
  at Object.<anonymous> (e2e/app-dir/actions/app-action.test.ts:1270:7)

● app-dir action handling › should work with interception routes

expect(received).toContain(expected) // indexOf

Expected substring: "interception-routes/test"
Received string:    "http://localhost:44723/interception-routes"

  1544 |     await retry(async () => {
  1545 |       // verify the URL is correct
> 1546 |       expect(await browser.url()).toContain('interception-routes/test')
       |                                   ^
  1547 |       // the intercepted text should appear
  1548 |       expect(await browser.elementById('modal-data').text()).toContain(
  1549 |         'in "modal"'

  at toContain (e2e/app-dir/actions/app-action.test.ts:1546:35)
  at retry (lib/next-test-utils.ts:806:14)
  at Object.<anonymous> (e2e/app-dir/actions/app-action.test.ts:1544:5)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Jan 10, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
buildDuration 33.4s 29.7s N/A
buildDurationCached 25.9s 25.7s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +7.8 kB
nextStartRea..uration (ms) 880ms 890ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
5306-HASH.js gzip 53.3 kB 53.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
index.html gzip 522 B 521 B N/A
link.html gzip 538 B 535 B N/A
withRouter.html gzip 518 B 518 B
Overall change 518 B 518 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
middleware-b..fest.js gzip 671 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 369 kB 369 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB N/A
app-page-tur..prod.js gzip 142 kB 142 kB N/A
app-page-tur..prod.js gzip 138 kB 138 kB N/A
app-page.run...dev.js gzip 357 kB 357 kB
app-page.run..prod.js gzip 126 kB 126 kB N/A
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.55 MB 1.55 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/01-10-_not_for_merge_flush_out_faulty_scroll_behavior Change
0.pack gzip 2.09 MB 2.09 MB ⚠️ +3.06 kB
index.pack gzip 74.7 kB 75 kB ⚠️ +373 B
Overall change 2.16 MB 2.17 MB ⚠️ +3.44 kB
Diff details
Diff for 5306-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: f6c8578

Base automatically changed from sebbie/01-10-ensure_metadata_doesn_t_break_scroll-to-top_on_navigation to canary January 10, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants