Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure correct app dir when building /_error fallback in dev #75354

Merged
merged 1 commit into from
Jan 27, 2025
+3 −2
Merged

Configure correct app dir when building /_error fallback in dev #75354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next/src/build/webpack-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,13 +304,13 @@ export default async function getBaseWebpackConfig(
dev?: boolean
entrypoints: webpack.EntryObject
isDevFallback?: boolean
pagesDir?: string
pagesDir: string | undefined
reactProductionProfiling?: boolean
rewrites: CustomRoutes['rewrites']
originalRewrites: CustomRoutes['rewrites'] | undefined
originalRedirects: CustomRoutes['redirects'] | undefined
runWebpackSpan: Span
appDir?: string
appDir: string | undefined
middlewareMatchers?: MiddlewareMatcher[]
noMangling?: boolean
jsConfig: any
Expand Down
1 change: 1 addition & 0 deletions packages/next/src/server/dev/hot-reloader-webpack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,7 @@ export default class HotReloaderWebpack implements NextJsHotReloaderInterface {
config: this.config,
buildId: this.buildId,
encryptionKey: this.encryptionKey,
appDir: this.appDir,
pagesDir: this.pagesDir,
rewrites: {
beforeFiles: [],
Expand Down
Loading