Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] More accurate stack assertions in terminal #75355

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 27, 2025

Failing test highlighting breakage in #75294

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Jan 27, 2025
Copy link
Member Author

eps1lon commented Jan 27, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 27, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
buildDuration 20.1s 18.1s N/A
buildDurationCached 17.3s 14.7s N/A
nodeModulesSize 393 MB 393 MB
nextStartRea..uration (ms) 469ms 462ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
5306-HASH.js gzip 54.3 kB 54.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 245 B 245 B
main-HASH.js gzip 34.6 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53.2 kB 53.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 521 B N/A
Overall change 538 B 538 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 211 kB 211 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
middleware-b..fest.js gzip 675 B 670 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
app-page-exp...dev.js gzip 394 kB 394 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 381 kB 381 kB
app-page.run..prod.js gzip 129 kB 129 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.9 kB 40.9 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.7 kB 60.7 kB
Overall change 1.67 MB 1.67 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test Change
0.pack gzip 2.11 MB 2.11 MB ⚠️ +3.64 kB
index.pack gzip 75.3 kB 75.6 kB ⚠️ +348 B
Overall change 2.18 MB 2.19 MB ⚠️ +3.99 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 7f3852b

@eps1lon eps1lon changed the title [test] More accurate stack assertion react-compiler.test [test] More accurate stack assertions in terminal Jan 27, 2025
@eps1lon eps1lon force-pushed the sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test branch 2 times, most recently from 3fe7ffe to acc2b92 Compare January 27, 2025 14:12
'\n at Root [Server] (<anonymous>)'
'\n at Root [Server] (<anonymous>)' +
// Just need some string to assert that this is the whole stack
'\n GET /no-accessed-data 200'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now lists more internals frames now that ignoreList is no longer filled in next-server bundles.

@ijjk
Copy link
Member

ijjk commented Jan 27, 2025

Tests Passed

@eps1lon eps1lon force-pushed the sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test branch from acc2b92 to 7f3852b Compare February 10, 2025 11:45
@eps1lon eps1lon marked this pull request as ready for review February 10, 2025 18:31
@eps1lon eps1lon requested review from huozhi and gaojude February 10, 2025 18:32
Copy link
Member Author

eps1lon commented Feb 10, 2025

Merge activity

  • Feb 10, 9:29 PM GMT+1: A user started a stack merge that includes this pull request via Graphite.
  • Feb 10, 9:30 PM GMT+1: A user merged this pull request with Graphite.

@eps1lon eps1lon merged commit 026f00e into canary Feb 10, 2025
131 checks passed
@eps1lon eps1lon deleted the sebbie/01-27-_test_more_accurate_stack_assertion_react-compiler.test branch February 10, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants