Skip to content

Conversation

SpareHeartz
Copy link

No description provided.

Comment on lines +26 to +28
run: |
npm install
grunt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow might fail because it doesn't install the Grunt CLI before running the grunt command. Consider either:

  1. Adding npm install -g grunt-cli before the grunt command:

    run: |
      npm install
      npm install -g grunt-cli
      grunt
    
  2. Or using npx to run the locally installed grunt:

    run: |
      npm install
      npx grunt
    

Alternatively, ensure grunt-cli is included in the project's package.json dependencies.

Suggested change
run: |
npm install
grunt
run: |
npm install
npx grunt

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +25 to +28
- name: Build
run: |
npm install
grunt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Build
run: |
npm install
grunt
- name: Setup corepack
run: |
npm i -g [email protected]
corepack enable
- name: Build
run: |
pnpm install
pnpm build

The workflow attempts to run npm install and grunt, but this repository uses pnpm as its package manager and does not have Grunt configured. This workflow will fail on every execution.

View Details

Analysis

GitHub Actions workflow uses wrong package manager and nonexistent build tool

What fails: .github/workflows/npm-grunt.yml runs npm install and grunt commands, but this repository uses [email protected] (specified in package.json line 311) and has no Grunt configuration.

How to reproduce:

# Check package manager configuration
grep packageManager package.json  # Shows "[email protected]"
ls -la | grep lock                 # Only pnpm-lock.yaml exists

# Verify no Grunt
find . -name "Gruntfile.*"         # No results
grep -i grunt package.json         # No grunt dependencies
grunt                              # Command not found (exit 127)

Result: The workflow would fail at both steps:

  • npm install ignores pnpm-lock.yaml and creates inconsistent dependencies
  • grunt command fails with "command not found"

Expected: All other workflows in .github/workflows/ use corepack to enable pnpm, then run pnpm install and pnpm build (see build_and_deploy.yml, test_examples.yml, etc.)

Fix: Updated workflow to use corepack + pnpm and replace grunt with pnpm build to match repository patterns.

@unstubbable unstubbable closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants