Skip to content

Commit

Permalink
feat: drop node@14 (#363)
Browse files Browse the repository at this point in the history
14.x reached EOL on 2023-04-30 https://github.com/nodejs/Release

This is normally considered semver major but since we haven't hit 1.0.0,
this is semver minor.

I also added `node@20` to CI but had to remove `@tensorflow/tfjs-node`
since it didn't work.
  • Loading branch information
styfle authored Sep 16, 2023
1 parent 0d46768 commit 712fee2
Show file tree
Hide file tree
Showing 6 changed files with 240 additions and 245 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node: [14, 16, 18]
node: [16, 18, 20]
runs-on: ${{ matrix.os }}
services:
redis:
Expand Down
9 changes: 4 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"@google-cloud/bigquery": "^4.1.4",
"@google-cloud/firestore": "^4.11.0",
"@sentry/node": "^5.5.0",
"@tensorflow/tfjs-node": "^3.12.0",
"@tpluscode/sparql-builder": "^0.3.12",
"@types/bindings": "^1.3.0",
"@types/estree": "^0.0.47",
Expand All @@ -47,16 +46,16 @@
"@types/node": "^14.14.37",
"analytics-node": "^3.4.0-beta.1",
"apollo-server-express": "^2.14.2",
"argon2": "^0.27.2",
"argon2": "^0.31.1",
"auth0": "^3.0.1",
"axios": "^0.21.2",
"azure-storage": "^2.10.3",
"bcrypt": "^5.0.1",
"browserify-middleware": "^8.1.1",
"bull": "^3.10.0",
"bullmq": "^1.74.2",
"bullmq": "^4.10.0",
"camaro": "^6.1.0",
"canvas": "^2.10.2",
"canvas": "^2.11.2",
"chromeless": "^1.5.2",
"consolidate": "^0.15.1",
"copy": "^0.3.2",
Expand Down Expand Up @@ -131,7 +130,7 @@
"when": "^3.7.8"
},
"engines": {
"node": ">=14"
"node": ">=16"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 0 additions & 2 deletions prepare-install.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,11 @@ if (isWin) {

//unlinkSync(join(__dirname, 'yarn.lock'));
// Delete the integration tests that will never work in Windows
unlinkSync(join(__dirname, 'test', 'integration', 'tensorflow.js'));
unlinkSync(join(__dirname, 'test', 'integration', 'argon2.js'));
unlinkSync(join(__dirname, 'test', 'integration', 'highlights.js'));
unlinkSync(join(__dirname, 'test', 'integration', 'hot-shots.js'));
unlinkSync(join(__dirname, 'test', 'integration', 'loopback.js'));
unlinkSync(join(__dirname, 'test', 'integration', 'playwright-core.js'));
delete pkg.devDependencies['@tensorflow/tfjs-node'];
delete pkg.devDependencies['argon2'];
delete pkg.devDependencies['highlights'];
delete pkg.devDependencies['hot-shots'];
Expand Down
2 changes: 0 additions & 2 deletions test/integration/tensorflow.js

This file was deleted.

2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"noUnusedParameters": true,
"noImplicitThis": true,
"outDir": "out",
"target": "es2020",
"target": "es2021",
"types": ["node"],
"skipLibCheck": true,
"strict": true
Expand Down
Loading

0 comments on commit 712fee2

Please sign in to comment.