Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error which occurs in vercel/vercel ci tests #447

Closed
wants to merge 3 commits into from
Closed

Show error which occurs in vercel/vercel ci tests #447

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d190f5
Show error which occurs in vercel/vercel ci tests
jeffsee55 Oct 24, 2024
1977c17
Undo test isolation
jeffsee55 Oct 24, 2024
1865b07
Simplify test case
jeffsee55 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/unit/a-url-error/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
const URLParser = typeof window === 'undefined' ? URL : 'b'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails with

 TypeError: Class constructor URL cannot be invoked without 'new'

The offending node is the URL Identifier, and I'm not able to see where it's getting invoked, I'm guessing due to some async nature of the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a regression from PR #429 ?

It added url to global, although this test doesn't have require('url') so may not be related.

Or maybe it was from the URL global here?

nft/src/analyze.ts

Line 187 in b3d2da0

URL: URL,

Copy link
Contributor

@onsclom onsclom Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More info on this:

  • The URL global you linked does seem to be the culprit!
  • Removing URL from globals makes this case work, but breaks other cases
  • The core problem exists well before 0.27.4, but 0.27.4 seems to trace more files which causes our test to hit this URL core problem now

Debugging this is tricky since the stack trace is very unhelpful. For example, replacing URL: URL with URL: () => console.trace('Called URL') and running this reproduction test gives the very unhelpful stack trace:

Trace: Called URL
    at Object.URL [as then] (/Users/onsclom/projects/nft/src/analyze.ts:188:13)

I can't figure out where URL is getting called from. Seems like from the then of some promise, but which one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@styfle Do you know how URL is getting invoked here? Happy to make a PR fixing this, but stuck on finding where exactly URL is getting invoked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its probably from computePureStaticValue() which is basically a static analysis form of eval() so it sets globals vars and local vars to try to compute a value.

nft/src/analyze.ts

Line 459 in b3d2da0

async function computePureStaticValue(expr: Node, computeBranches = true) {

Loading