Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blob): inline bytes module to avoid bundling issues #820

Merged
merged 7 commits into from
Jan 17, 2025
Merged

fix(blob): inline bytes module to avoid bundling issues #820

merged 7 commits into from
Jan 17, 2025

Conversation

vvo
Copy link
Member

@vvo vvo commented Jan 17, 2025

fixes #818

@vvo vvo requested review from correttojs and luismeyer January 17, 2025 13:00
@vvo vvo self-assigned this Jan 17, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1737888

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vercel-storage-next-integration-test-suite ✅ Ready (Inspect) Visit Preview Jan 17, 2025 1:48pm

@vvo vvo changed the title fix(blob): ensure bytes module is loaded correctly for some bundlers fix(blob): inline bytes module to avoid bundling issues Jan 17, 2025
@vvo vvo enabled auto-merge (squash) January 17, 2025 13:57
@vvo vvo merged commit a72c93d into main Jan 17, 2025
12 checks passed
@vvo vvo deleted the fix/blob/nuxt-bytes-imports branch January 17, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@correttojs correttojs correttojs approved these changes

@luismeyer luismeyer Awaiting requested review from luismeyer

Assignees

@vvo vvo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vercel/blob _nuxt/node_modules/bytes/index.js does not provide an export named 'default'
2 participants
@vvo @correttojs