Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Sync PublicConfiguration.onDiscarded tsdoc with SWR official website #4076

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samuel871211
Copy link
Contributor

@samuel871211 samuel871211 commented Jan 26, 2025

Problem

The TSDoc for PublicConfiguration.onDiscarded is inconsistent with the description on the SWR official website.

Changes

Updated TSDoc to match the SWR official website:

  • Original: callback function when a request is ignored
  • Updated: callback function when a request is ignored due to race conditions

Related Issues

#2979

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@samuel871211 samuel871211 changed the title doc: tsdoc for PublicConfiguration.onDiscarded doc: Sync PublicConfiguration.onDiscarded tsdoc with official documentation Feb 9, 2025
@samuel871211 samuel871211 changed the title doc: Sync PublicConfiguration.onDiscarded tsdoc with official documentation doc: Sync PublicConfiguration.onDiscarded tsdoc with SWR official documentation Feb 9, 2025
@samuel871211 samuel871211 changed the title doc: Sync PublicConfiguration.onDiscarded tsdoc with SWR official documentation doc: Sync PublicConfiguration.onDiscarded tsdoc with SWR official website Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant