-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(visitor): break up visitor to multiple modules (#9306)
### Description This is a prefactor to break up `visitor.rs` into multiple files. This is primarily just moving code around, but there are a few more in depth changes: - 2873556 changes `TaskWarning` to only be constructed if there are missing envs, removing the need to check later on - 88e98c5 changes so we no longer call `which` for every task to find the package manager binary. We instead call this on construction, but will only handle the error case on actual command creation. I highly recommend reviewing each commit on it's own. All commits that move code do only that so hopefully that makes it easier to review. ### Testing Instructions Integration tests and some basic manual testing.
- Loading branch information
1 parent
7d9ccae
commit cff7529
Showing
9 changed files
with
1,404 additions
and
1,246 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.