Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vim Motions Support to TurboRepo UI Input Handling #9243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlvaroParker
Copy link

Summary:

This PR introduces support for basic Vim-style key bindings within the tui component of TurboRepo, specifically for pane navigation. The goal is to improve navigation efficiency for users familiar with Vim-like key motions.

Key Changes:

  • Added support for h, j, k, and l Vim keybinds for interactive mode:
    • Ctrl+h: Exit interactive mode.
    • Ctrl+j: Move down.
    • Ctrl+k: Move up.
    • Ctrl+l: Enter interactive mode.
  • General Vim-style motions:
    • j: Move down.
    • k: Move up.
    • l: Enter interactive mode.

Motivation:
Adding these motions provides a more intuitive interface for users familiar with Vim commands, enhancing navigation within the pane section of the TurboRepo UI.

Related discussion

@AlvaroParker AlvaroParker requested a review from a team as a code owner October 10, 2024 16:34
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Oct 10, 2024
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:31pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:31pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:31pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:31pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:31pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:31pm

Copy link

vercel bot commented Oct 10, 2024

@AlvaroParker is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@AlvaroParker
Copy link
Author

Don't really know why the workflows are failing. I updated my branch, waiting for approval : )

@dimitropoulos
Copy link
Contributor

hey just to keep you in the loop, I was reviewing this just now and we're gonna talk about it at our next team meeting and get back to you: there are some future plans for some of these keys (beyond just j and k) and we need to make sure we don't disrupt those plans.

@dimitropoulos
Copy link
Contributor

hey @AlvaroParker so I checked with the rest of the team and we'd like to just do j and k and nothing more - would you please update this PR to only add those keys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants