Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs link checker #9311

Merged
merged 31 commits into from
Oct 23, 2024
Merged

fix docs link checker #9311

merged 31 commits into from
Oct 23, 2024

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented Oct 22, 2024

Description

We've been having issues with the docs link checker. It's not in a great state, so in this PR the goals are:

  • fix the problem that's been constantly failing
  • get it working to run locally (before, it only runs on PRs and will immediately fail locally if not)
  • update the tooling associated with doing this (much of it is years and years out of date).

Testing Instructions

cd docs
pnpm check-links

See failing CI run: https://github.com/vercel/turborepo/actions/runs/11467995496/job/31912111207

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 5:47pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm

@dimitropoulos
Copy link
Contributor Author

(note) did a final "demonstrate that the action failure works as expected" here: https://github.com/vercel/turborepo/actions/runs/11485026631/job/31964158530?pr=9311 before merging

@dimitropoulos dimitropoulos merged commit b8a54d6 into main Oct 23, 2024
44 checks passed
@dimitropoulos dimitropoulos deleted the dimitri/docs-tests branch October 23, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants