feat(query): reverse tracing #9319
Open
+568
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
force-pushed
the
nicholasyang/reverse-turbo-trace
branch
from
255d821
to
f86b92f
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
…ixes in a repo where we may have multiple tsconfigs
NicholasLYang
commented
Oct 25, 2024
|
|
||
| let mut parser = Parser::new_from(Capturing::new(lexer)); | ||
| pub async fn reverse_trace(mut self) -> TraceResult { | ||
| let files = match globwalk::globwalk( |
There was a problem hiding this comment.
I'd love at some point to combine the glob walking and the import resolution so that we can have more concurrency. Right now we have to walk the entire repo, then do the import resolution step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements an MVP of reverse tracing. Basically goes through all the JavaScript/TypeScript files in the repo, checks which ones import the reverse traced file, and returns those. Does this concurrently with a
JoinSet.Also adds code to detect if a tsconfig is in scope for a file and if so, add it to the resolver. That way custom aliases work.
Testing Instructions
Added some tests including a monorepo setup with tsconfigs in the packages that define aliases