chore(tui): dim pane text helpers and remove dead code. #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
anthonyshew
changed the title
anthonyshew
commented
Nov 29, 2024
| @@ -34,12 +34,8 @@ impl<'a, W> TerminalPane<'a, W> { | |||
| } | |||
| } | |||
|
|
|||
| fn highlight(&self) -> bool { | |||
There was a problem hiding this comment.
Dead code! There's no border to highlight anymore.
anthonyshew
commented
Nov 29, 2024
| @@ -77,13 +73,12 @@ impl<'a, W> Widget for &TerminalPane<'a, W> { | |||
| { | |||
| let screen = self.terminal_output.parser.screen(); | |||
| let block = Block::default() | |||
| .title(self.terminal_output.title(self.task_name)) | |||
| .title_bottom(self.footer()) | |||
| .style(if self.highlight() { | |||
There was a problem hiding this comment.
We don't do these yellow highlights. The only place in the program we do yellow highlights now is in the task table (not here), so we can remove this.
anthonyshew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I started noticing that my logs and the text help were looking quite similar. This differentiates the two so its more obvious at a glance.
Testing Instructions