-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): remove goreleaser #9905
Draft
chris-olszewski
wants to merge
5
commits into
main
Choose a base branch
from
olszewski/chore_remove_goreleaser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+672
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
force-pushed
the
olszewski/chore_remove_goreleaser
branch
from
February 5, 2025 21:39
8de401e
to
b596867
Compare
chris-olszewski
force-pushed
the
olszewski/chore_remove_goreleaser
branch
from
February 5, 2025 22:12
b596867
to
ee40557
Compare
chris-olszewski
force-pushed
the
olszewski/chore_remove_goreleaser
branch
from
February 6, 2025 00:13
1160e15
to
869d3a3
Compare
chris-olszewski
force-pushed
the
olszewski/chore_remove_goreleaser
branch
from
February 6, 2025 01:04
869d3a3
to
4bb3757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finally remove
goreleaser
after Go left the codebase a year ago. This does almost exactly what we were doing withgoreleaser
except we now base the native releases off ofversion.txt
contents like every other package and not Git tags.I highly recommend reading each commit especially the first one as I mark up the
goreleaser
flow we were using explaining what exactly it did.Testing Instructions
The dry run got up to the publishing step! All of the
tgz
files look correct: logsRunning locally, the contents of
tar.gz
looks to be correct:What hasn't been tested is the actual
npm publish
call, but I am fairly certain that will work as it's a very similar shell command to the one used ingoreleaser