Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): remove goreleaser #9905

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Feb 5, 2025

Description

Finally remove goreleaser after Go left the codebase a year ago. This does almost exactly what we were doing with goreleaser except we now base the native releases off of version.txt contents like every other package and not Git tags.

I highly recommend reading each commit especially the first one as I mark up the goreleaser flow we were using explaining what exactly it did.

Testing Instructions

The dry run got up to the publishing step! All of the tgz files look correct: logs

Running locally, the contents of tar.gz looks to be correct:

[0 olszewski@Chriss-MacBook-Pro] /tmp/turboreleaser-test $ tar xzf /Users/olszewski/code/vercel/turborepo/cli/dist/darwin-x64-2.4.1-canary.0.tar.gz 
[0 olszewski@Chriss-MacBook-Pro] /tmp/turboreleaser-test $ ls
README.md       bin             package.json
[0 olszewski@Chriss-MacBook-Pro] /tmp/turboreleaser-test $ bat README.md 
───────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: README.md
───────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ # `turbo`
   2   │ 
   3   │ This is a platform-specific binary for Turborepo, a monorepo build system. See https://github.com/vercel/turborepo for details.
───────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
[0 olszewski@Chriss-MacBook-Pro] /tmp/turboreleaser-test $ bat package.json 
───────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: package.json
───────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ {
   2   │   "name": "turbo-darwin-64",
   3   │   "version": "2.4.1-canary.0",
   4   │   "description": "The darwin-x64 binary for turbo, a monorepo build system.",
   5   │   "repository": "https://github.com/vercel/turborepo",
   6   │   "bugs": "https://github.com/vercel/turborepo/issues",
   7   │   "homepage": "https://turbo.build/repo",
   8   │   "license": "MIT",
   9   │   "os": [
  10   │     "darwin"
  11   │   ],
  12   │   "cpu": [
  13   │     "x64"
  14   │   ],
  15   │   "preferUnplugged": true
  16   │ }
───────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
[0 olszewski@Chriss-MacBook-Pro] /tmp/turboreleaser-test $ ls bin 
turbo

What hasn't been tested is the actual npm publish call, but I am fairly certain that will work as it's a very similar shell command to the one used in goreleaser

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:04am

@chris-olszewski chris-olszewski force-pushed the olszewski/chore_remove_goreleaser branch from 8de401e to b596867 Compare February 5, 2025 21:39
@chris-olszewski chris-olszewski force-pushed the olszewski/chore_remove_goreleaser branch from b596867 to ee40557 Compare February 5, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant