[cli] Allows warnings for ls --update-required to show for deprecated versions
#12856
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ee456f The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trek
requested review from
TooTallNate,
EndangeredMassa,
onsclom,
jeffsee55 and
erikareads
as code owners
onsclom
approved these changes
Jan 14, 2025
EndangeredMassa
requested changes
Jan 14, 2025
| nodeVersion.discontinueDate && | ||
| nodeVersion.discontinueDate.valueOf() > Date.now() | ||
| nodeVersion.deprecationDate && | ||
| nodeVersion.deprecationDate.valueOf() > Date.now() |
There was a problem hiding this comment.
suggestion (blocking): check both dates
I think we want to check for either date being in the past. Or, we should add deprecationDate to all currently discontinued versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only show a warning if a runtime version's
discontinueDatehas passed, but customers should be able to run this before that date to see what they need to change. Setting the date for the soon-to-be removed node@16 to the date from the changelog