-
Notifications
You must be signed in to change notification settings - Fork 80
Test workflow-server 88 #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ): { baseUrl: string; usingProxy: boolean } => { | ||
| const projectConfig = config?.projectConfig; | ||
| const defaultUrl = 'https://vercel-workflow.com/api'; | ||
| const defaultUrl = 'https://workflow-server-q11w7a7sc.vercel.sh/api'; // https://vercel-workflow.com/api'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const defaultUrl = 'https://workflow-server-q11w7a7sc.vercel.sh/api'; // https://vercel-workflow.com/api'; | |
| const defaultUrl = 'https://vercel-workflow.com/api'; |
The default API URL was changed to a hardcoded Vercel deployment URL with a specific hash, which appears to be a temporary development URL rather than a stable production endpoint.
View Details
Analysis
Hardcoded Vercel preview deployment URL breaks published npm package
What fails: @workflow/world-vercel package published to npm contains hardcoded temporary Vercel preview deployment URL https://workflow-server-q11w7a7sc.vercel.sh/api instead of the stable production endpoint, causing all users of the package without explicit configuration to connect to a temporary development deployment that will eventually be removed.
How to reproduce:
- Install
@workflow/world-vercelpackage from npm (version 4.0.1-beta.5 or later with this commit) - Call
createVercelWorld()without providing abaseUrlconfig - Any API requests will attempt to connect to
https://workflow-server-q11w7a7sc.vercel.sh/api - Verify in network logs or debugging that requests go to this preview URL, which will fail when the preview deployment expires
Result: API requests fail when the Vercel preview deployment (identified by q11w7a7sc) is removed or redeployed, which is expected behavior for temporary deployments.
Expected: API requests should connect to the stable production endpoint https://vercel-workflow.com/api by default. Users should only be forced to a different endpoint if they explicitly configure baseUrl or provide projectId and teamId for proxy-based requests.
Background: The change was introduced in commit 0c519b5 ("Test workflow-server 88") which replaced the stable production URL with a Vercel preview deployment identifier. The commented-out code on the same line (// https://vercel-workflow.com/api') indicates this was a temporary test change that was accidentally committed. The package's publishConfig in package.json shows it is publicly published to npm, making this a breaking change for all package users.
No description provided.