Skip to content

Conversation

@TooTallNate
Copy link
Member

No description provided.

@vercel
Copy link
Contributor

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Comment Nov 5, 2025 5:35pm
example-nextjs-workflow-webpack Ready Ready Preview Comment Nov 5, 2025 5:35pm
example-workflow Ready Ready Preview Comment Nov 5, 2025 5:35pm
workbench-nitro-workflow Ready Ready Preview Comment Nov 5, 2025 5:35pm
workbench-nuxt-workflow Ready Ready Preview Comment Nov 5, 2025 5:35pm
workbench-sveltekit-workflow Ready Ready Preview Comment Nov 5, 2025 5:35pm
workbench-vite-workflow Ready Ready Preview Comment Nov 5, 2025 5:35pm
workflow-docs Ready Ready Preview Comment Nov 5, 2025 5:35pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

⚠️ No Changeset found

Latest commit: 0c519b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

): { baseUrl: string; usingProxy: boolean } => {
const projectConfig = config?.projectConfig;
const defaultUrl = 'https://vercel-workflow.com/api';
const defaultUrl = 'https://workflow-server-q11w7a7sc.vercel.sh/api'; // https://vercel-workflow.com/api';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const defaultUrl = 'https://workflow-server-q11w7a7sc.vercel.sh/api'; // https://vercel-workflow.com/api';
const defaultUrl = 'https://vercel-workflow.com/api';

The default API URL was changed to a hardcoded Vercel deployment URL with a specific hash, which appears to be a temporary development URL rather than a stable production endpoint.

View Details

Analysis

Hardcoded Vercel preview deployment URL breaks published npm package

What fails: @workflow/world-vercel package published to npm contains hardcoded temporary Vercel preview deployment URL https://workflow-server-q11w7a7sc.vercel.sh/api instead of the stable production endpoint, causing all users of the package without explicit configuration to connect to a temporary development deployment that will eventually be removed.

How to reproduce:

  1. Install @workflow/world-vercel package from npm (version 4.0.1-beta.5 or later with this commit)
  2. Call createVercelWorld() without providing a baseUrl config
  3. Any API requests will attempt to connect to https://workflow-server-q11w7a7sc.vercel.sh/api
  4. Verify in network logs or debugging that requests go to this preview URL, which will fail when the preview deployment expires

Result: API requests fail when the Vercel preview deployment (identified by q11w7a7sc) is removed or redeployed, which is expected behavior for temporary deployments.

Expected: API requests should connect to the stable production endpoint https://vercel-workflow.com/api by default. Users should only be forced to a different endpoint if they explicitly configure baseUrl or provide projectId and teamId for proxy-based requests.

Background: The change was introduced in commit 0c519b5 ("Test workflow-server 88") which replaced the stable production URL with a Vercel preview deployment identifier. The commented-out code on the same line (// https://vercel-workflow.com/api') indicates this was a temporary test change that was accidentally committed. The package's publishConfig in package.json shows it is publicly published to npm, making this a breaking change for all package users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants