Change RetryableError "retryAfter" option number value to represent milliseconds instead of seconds
#240
+74
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: faaf9eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
pranaygp
reviewed
Nov 6, 2025
| if (response.status === 429) { | ||
| const retryAfter = response.headers.get('Retry-After'); | ||
| // Customize the duration before retrying | ||
| // Customize the duration before retrying (assume "Retry-After" is an ISO string) |
Collaborator
There was a problem hiding this comment.
retry after header js meant to be either seconds, or a HTTP Date format - not ISO
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Retry-After
.changeset/cute-drinks-swim.md
Outdated
| "@workflow/core": patch | ||
| --- | ||
|
|
||
| Change `RetryableError` "retryAfter" option number value to represent milliseconds instead of seconds |
Collaborator
There was a problem hiding this comment.
let's emphasize the breaking change nature. I wanna get in the habit of doing that so that LLMs can easily do migrations (and create migration guides)
| throw new RetryableError( // [!code highlight] | ||
| `Rate limited by ${url}`, // [!code highlight] | ||
| { retryAfter: `${retryAfter} seconds` } // [!code highlight] | ||
| { retryAfter: new Date(retryAfter) } // [!code highlight] |
| // Delay the retry until after a timeout (assume "Retry-After" is an ISO string) | ||
| throw new RetryableError("Too many requests. Retrying...", { // [!code highlight] | ||
| retryAfter: parseInt(retryAfter), // [!code highlight] | ||
| retryAfter: new Date(retryAfter), // [!code highlight] |
|
|
||
| if (response.status >= 500) { | ||
| // Exponential backoffs | ||
| // Exponential backoffs (in milliseconds) |
pranaygp
approved these changes
Nov 6, 2025
… milliseconds instead of seconds
TooTallNate
force-pushed
the
11-05-change_retryableerror_retryafter_option_number_value_to_represent_milliseconds_instead_of_seconds
branch
from
e3c655b to
faaf9eb
Compare
TooTallNate
force-pushed
the
graphite-base/240
branch
from
d0618bc to
bf170ad
Compare
TooTallNate
deleted the
11-05-change_retryableerror_retryafter_option_number_value_to_represent_milliseconds_instead_of_seconds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
RetryableErrorto use milliseconds instead of seconds for numericretryAftervalues.What changed?
RetryableErrorclass to interpret numericretryAftervalues as milliseconds instead of seconds@workflow/utilspackage to use theparseDurationToDatefunctionHow to test?
RetryableErrorwith differentretryAfterformats:Why make this change?
Using milliseconds as the unit for numeric time values is more consistent with JavaScript conventions (like
setTimeoutand other timing functions). This change makes the API more intuitive for JavaScript developers and aligns with standard practices in the ecosystem.