Skip to content

Commit

Permalink
[Warnings] Suppressed Bison Deprecation Warnings
Browse files Browse the repository at this point in the history
Suppressed the Bison deprecation warnings for SDCParse and BlifParse
since the fix for the deprecation requires Bison 3.3, but the current
minimum version of Bison is 3.0

Some development machines using VPR cannot be upgraded to Bison 3.3
easily, so for now the deprecation warnings are just being suppressed
until all machines are on Bison 3.3

PR #2529 tracks this issue and contains the code to fix the
deprecations.
  • Loading branch information
AlexandreSinger committed May 16, 2024
1 parent f4bd1be commit 0c25ec3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion libs/EXTERNAL/libblifparse/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ file(GLOB_RECURSE PARSER_SOURCES src/blif*.y)
#Make the flex and bison targets
flex_target(BlifLexer ${LEXER_SOURCES} ${CMAKE_CURRENT_BINARY_DIR}/blif_lexer.gen.cpp
COMPILE_FLAGS --header-file=${CMAKE_CURRENT_BINARY_DIR}/blif_lexer.gen.hpp)
bison_target(BlifParser ${PARSER_SOURCES} ${CMAKE_CURRENT_BINARY_DIR}/blif_parser.gen.cpp)
# Suppress deprecation warnings. See PR #2529
bison_target(BlifParser ${PARSER_SOURCES} ${CMAKE_CURRENT_BINARY_DIR}/blif_parser.gen.cpp
COMPILE_FLAGS -Wdeprecated)
add_flex_bison_dependency(BlifLexer BlifParser)

#Suppress warnings in Flex/Bison generated files
Expand Down
4 changes: 3 additions & 1 deletion libs/EXTERNAL/libsdcparse/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ file(GLOB_RECURSE PARSER_SOURCES src/sdc*.y)
#Make the flex and bison targets
flex_target(SdcLexer ${LEXER_SOURCES} ${CMAKE_CURRENT_BINARY_DIR}/sdc_lexer.gen.cpp
COMPILE_FLAGS --header-file=${CMAKE_CURRENT_BINARY_DIR}/sdc_lexer.gen.hpp)
bison_target(SdcParser ${PARSER_SOURCES} ${CMAKE_CURRENT_BINARY_DIR}/sdc_parser.gen.cpp)
# Suppress deprecation warnings. See PR #2529
bison_target(SdcParser ${PARSER_SOURCES} ${CMAKE_CURRENT_BINARY_DIR}/sdc_parser.gen.cpp
COMPILE_FLAGS -Wdeprecated)
add_flex_bison_dependency(SdcLexer SdcParser)


Expand Down

0 comments on commit 0c25ec3

Please sign in to comment.