Fixing ODIN II and blifexplorer Compiler Warnings. #2549
Conversation
github-actions
bot
added
Odin
There was a problem hiding this comment.
Hi @navidjafarof , thank you so much for this PR! This fixes all of the warnings in the CI runs, especially the ones described in issue #2518
I made a small note on blif_parser.y and sdc_parser.y. These are being handled specially in another PR since they require changing the minimum version of Bison.
| @@ -34,7 +34,7 @@ | |||
| %define api.namespace {blifparse} | |||
|
|
|||
| /* Name the parser class */ | |||
| %define parser_class_name {Parser} | |||
| %define api.parser.class {Parser} | |||
There was a problem hiding this comment.
@navidjafarof As I mentioned in the VTR Industry Sync-Up, the api.parser.class was not added until Bison 3.3. The minimum version of Bison for VTR is currently set to 3.0; and since some users of VTR may be using older versions of Ubuntu it is not trivial to upgrade the version of Bison.
This issue is currently being tracked by PR #2529
We plan on just suppressing the deprecation warnings for liblifparse and libsdcparse (specifically for these files) until all machines are up to date.
| @@ -34,7 +34,7 @@ | |||
| %define api.namespace {sdcparse} | |||
|
|
|||
| /* Name the parser class */ | |||
| %define parser_class_name {Parser} | |||
| %define api.parser.class {Parser} | |||
There was a problem hiding this comment.
See the above message regarding the use of api.parser.class
|
@AlexandreSinger @navidjafarof : do you want to back out of the api.parser.class changes so we can merge the other changes? |
|
@vaughnbetz @AlexandreSinger The PR is ready to merge. |
|
Thanks @navidjafarof |
Description
This pull request is aimed to fix the warnings in ODIN II and blifexplorer.
Related Issue
#2295
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: