Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgraded Runners to Ubuntu 24.04 #2848

Merged

Conversation

AlexandreSinger
Copy link
Contributor

@AlexandreSinger AlexandreSinger commented Dec 21, 2024

Upgraded the GitHub-hosted runners from Ubuntu 22.04 to Ubuntu 24.04. This ensures that all changes to VTR will work on the most recent version of Ubuntu (as well as being warning clean).

Removed the prior tests for Ubuntu 24.04.

Added a tests to ensure Ubuntu 22.04 remains warning clean as well.

Change Summary:

  • Changed the default GCC version (the one most tests are built with) from GCC-11 to GCC-13 (the default on Ubuntu 24.04).
  • Changed the runners for all tests from ubuntu-22.04 to ubuntu-24.04.
  • Changed the python version for all tests from 3.10.10 to 3.12.3 (the default on Ubuntu 24.04). However, the Python Lint testcase needed to remain on 3.10.10 due to new linting errors that showed up on 3.12.3; this should be resolved in a different PR.
  • Turned off IPO on the Regression tests, since they are used to check for warning cleanliness (IPO can cause some warnings) and do not need to be performant; so they can compile faster without IPO.
  • Updated the Compatibility tests:
    • Removed GCC-9 and GCC-10
    • Removed Clang-11, Clang-12, Clang-13, and Clang-14
    • Added GCC-14
    • Added Clang-15, Clang-16, Clang-17, Clang-18
  • Added a compatibility test for Ubuntu 22.04 (with GCC-11) to ensure that it is also warning clean.

The only code that needed to be modified was around some of the Eigen include statements, since Eigen has some small warnings in GCC-13.

@github-actions github-actions bot added infra Project Infrastructure lang-shell Shell scripts (bash etc.) labels Dec 21, 2024
@AlexandreSinger AlexandreSinger force-pushed the feature-ci-noble-upgrade branch 2 times, most recently from 5b528bd to ce47c36 Compare December 23, 2024 23:27
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Dec 23, 2024
@AlexandreSinger AlexandreSinger force-pushed the feature-ci-noble-upgrade branch from ce47c36 to 90b21bd Compare January 10, 2025 15:45
Upgraded the GitHub-hosted runners from Ubuntu 22.04 to Ubuntu 24.04.
This ensures that all changes to VTR will work on the most recent
version of Ubuntu (as well as being warning clean).

Removed the prior tests for Ubuntu 24.04.

Added a tests to ensure Ubuntu 22.04 remains warning clean as well.
@AlexandreSinger AlexandreSinger force-pushed the feature-ci-noble-upgrade branch from 90b21bd to dffad27 Compare January 10, 2025 15:55
@AlexandreSinger
Copy link
Contributor Author

AlexandreSinger commented Jan 10, 2025

@vaughnbetz This has passed CI. The required tests which say "expected" above are the old tests that I turned off in the CI. Since they were labelled as required, GitHub is expecting them to eventually run. What do you think of this PR? Also, are you ok with me making the "expected" tests above no longer required?

I have provided a summary of all of the CI changes in the description above.

@vaughnbetz
Copy link
Contributor

Looks great, thanks! Yes, please remove the tests we're no longer running from the required list.

@vaughnbetz vaughnbetz merged commit d7e62db into verilog-to-routing:master Jan 10, 2025
37 checks passed
@AlexandreSinger AlexandreSinger deleted the feature-ci-noble-upgrade branch January 10, 2025 20:19
@AlexandreSinger
Copy link
Contributor Author

The tests have been removed from the merge rules. We can verify that these changes took affect the next time a PR tries to run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure lang-cpp C/C++ code lang-shell Shell scripts (bash etc.) VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants