Scatter-gather patterns for 3D architectures #3276
Open
+2,313
−3,703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e function that it calls
soheilshahrouz
changed the title
There was a problem hiding this comment.
Gave a quick review.
@soheilshahrouz I love the cleanups you do, but man you got to split them across PRs; there's so much to review!
Comment on lines
+158
to
+159
| // TODO: handle CHANZ nodes | ||
|
|
There was a problem hiding this comment.
TODO remaining in final code
|
|
||
| int from_layer_num = rr_graph.node_layer(from_node); | ||
| int to_layer_num = rr_graph.node_layer(to_node); | ||
| // TODO: handle CHANZ nodes that span multiple layers |
There was a problem hiding this comment.
TODO again. Not saying that you have to fix these right now, but a reminder that it is there. I sometimes forget about my TODOs so I'm just making sure that it's intended.
| const auto& grid = device_ctx.grid; | ||
|
|
||
| const size_t num_layers = grid.get_num_layers(); | ||
| const size_t chan_type_dim_size = (num_layers == 1) ? 2 : 3; |
There was a problem hiding this comment.
Add comment explaining this.
| if (is_chanxy(from_type) || is_chanz(from_type)) { | ||
| int from_layer_num = rr_graph.node_layer(from_node); | ||
| int to_layer_num = rr_graph.node_layer(to_node); | ||
| // TODO: handle CHANZ nodes |
There was a problem hiding this comment.
TODO. Again, just reminding that it exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes: