BENCH-4272: Retry post-startup script commands that may fail due to to transient network issues #129
Conversation
…ransient network issues
june-hua
force-pushed
the
BENCH-4272-Log-startup-script-errors-to-local-file-same-pattern-as-Vertex-AI
branch
from
5167a41
to
60f1643
Compare
| @@ -14,13 +14,15 @@ readonly USER_NAME="${1}" | |||
| readonly WORK_DIRECTORY="${2}" | |||
There was a problem hiding this comment.
Exporting the variables that are used by the scripts that are called later. This is because those scripts cannot be sourced if we support retries.
Exporting the variables will make the variables available to those scripts.
There was a problem hiding this comment.
i see... can we do it per line.
like readonly USER_NAME
export USER_NAME
so when someone wants to delete or change the variable name, it's harder to miss.
| set -o nounset | ||
| set -o pipefail | ||
| set -o xtrace | ||
|
|
There was a problem hiding this comment.
check if cli is installed and only install if it's not
startupscript/post-startup.sh
Outdated
|
|
||
| # Startup script status is propagated out to VM guest attributes | ||
| readonly STATUS_ATTRIBUTE="startup_script/status" | ||
| readonly MESSAGE_ATTRIBUTE="startup_script/message" | ||
| EXPORT STATUS_ATTRIBUTE MESSAGE_ATTRIBUTE |
There was a problem hiding this comment.
Whoopsies let me fix that!
| @@ -14,13 +14,15 @@ readonly USER_NAME="${1}" | |||
| readonly WORK_DIRECTORY="${2}" | |||
There was a problem hiding this comment.
i see... can we do it per line.
like readonly USER_NAME
export USER_NAME
so when someone wants to delete or change the variable name, it's harder to miss.
1. Only install CLI if not already installed 2. Update file comments 3. Put export variables in separate line.
june-hua
force-pushed
the
BENCH-4272-Log-startup-script-errors-to-local-file-same-pattern-as-Vertex-AI
branch
from
7ca7e6d
to
cb9523c
Compare
No description provided.