tests: add ecdsa noble curves test vectors #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obatirou
commented
Nov 19, 2024
| string signature; | ||
| } | ||
|
|
||
| function testVectorsNobleCurves_verify_WithPublicKey() public { |
There was a problem hiding this comment.
There is no test with verify_WithAddress, only verify_WithPublicKey for now.
It should be equivalent so I think this is enough but happy to add more tests / make changes if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, after the investigation RFC6979-implementation-analysis, here is the PR to add the ecdsa test vectors from noble curves.
This PR is the second part of #23