Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go.mod to controller runtime 0.15.0 #195

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update go.mod to controller runtime 0.15.0 #195

wants to merge 8 commits into from

Conversation

michael-cico
Copy link
Member

@michael-cico michael-cico commented Sep 14, 2023 •
edited
Loading

Update to controllerruntime 0.15.0, and fix up any code changes required.

  • Watch interfaces changed a bit, source.Kind is now a function that is used when creating a Watch
  • Modify the WatchDescriptor type and usages accordingly
  • A few other knock-on effects caused by other version changes introduced by the controllerruntime update

@michael-cico michael-cico marked this pull request as draft September 14, 2023 20:08
@michael-cico michael-cico marked this pull request as ready for review September 14, 2023 22:19
bobdonat
bobdonat reviewed Sep 15, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdonat bobdonat bobdonat left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-cico @bobdonat