-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 23241 migrate currency revaluation 17 aka #4
Feature 23241 migrate currency revaluation 17 aka #4
Conversation
9b26e07
to
45f48f1
Compare
45f48f1
to
dfa6476
Compare
28dd038
to
2a0b92a
Compare
Module was not migrated by OCA, so we migrating it on forked OCA's account-closing v17 repository. |
@Qlasta why not contribute to OCA? as I see, there is not a lot of fixes required. And it will be hard to maintain this module if OCA will migrate it without these fixes. |
2a0b92a
to
b4effb9
Compare
@AurelijaNorvaisaite I submitted the same changes to OCA, not sure how long it will take for them to approve. @augustinasra, is this module urgent for us, or we can wait until OCA approves it? |
@Qlasta I see that you submitted, but they won't approve it as it does not follow required guidelines. It should look like something like this: |
@AurelijaNorvaisaite thanks, understood, will change my PR. |
@Qlasta it's not urgent, so we can wait for OCA approval |
closing for now, PR provided to OCA. (no.302) |
migrate to v17 with fixes.
https://hive.versada.eu/work_packages/23241/activity