Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 23241 migrate currency revaluation 17 aka #4

Closed

Conversation

Qlasta
Copy link

@Qlasta Qlasta commented Aug 26, 2024

@Qlasta Qlasta force-pushed the feature-23241-migrate-currency-revaluation-17-aka branch 2 times, most recently from 9b26e07 to 45f48f1 Compare August 26, 2024 14:04
@Qlasta Qlasta force-pushed the feature-23241-migrate-currency-revaluation-17-aka branch from 45f48f1 to dfa6476 Compare August 26, 2024 14:09
@Qlasta Qlasta force-pushed the feature-23241-migrate-currency-revaluation-17-aka branch from 28dd038 to 2a0b92a Compare August 27, 2024 09:00
@Qlasta Qlasta marked this pull request as ready for review August 27, 2024 09:01
@Qlasta
Copy link
Author

Qlasta commented Aug 27, 2024

Module was not migrated by OCA, so we migrating it on forked OCA's account-closing v17 repository.

@AurelijaNorvaisaite
Copy link

@Qlasta why not contribute to OCA? as I see, there is not a lot of fixes required. And it will be hard to maintain this module if OCA will migrate it without these fixes.

@Qlasta Qlasta force-pushed the feature-23241-migrate-currency-revaluation-17-aka branch from 2a0b92a to b4effb9 Compare August 27, 2024 11:16
@Qlasta
Copy link
Author

Qlasta commented Aug 27, 2024

@Qlasta why not contribute to OCA? as I see, there is not a lot of fixes required. And it will be hard to maintain this module if OCA will migrate it without these fixes.

@AurelijaNorvaisaite I submitted the same changes to OCA, not sure how long it will take for them to approve. @augustinasra, is this module urgent for us, or we can wait until OCA approves it?
I suggest we can at least have it in our system for testing until they approves.

@AurelijaNorvaisaite
Copy link

@Qlasta I see that you submitted, but they won't approve it as it does not follow required guidelines. It should look like something like this:
https://github.com/OCA/account-closing/pull/248/commits
With all commits from previous versions.
Here you can find technical method how to migrate: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

@Qlasta
Copy link
Author

Qlasta commented Aug 27, 2024

@Qlasta I see that you submitted, but they won't approve it as it does not follow required guidelines. It should look like something like this: https://github.com/OCA/account-closing/pull/248/commits With all commits from previous versions. Here you can find technical method how to migrate: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

@AurelijaNorvaisaite thanks, understood, will change my PR.

@augustinasra
Copy link

@Qlasta it's not urgent, so we can wait for OCA approval

@Qlasta
Copy link
Author

Qlasta commented Aug 28, 2024

closing for now, PR provided to OCA. (no.302)

@Qlasta Qlasta closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants