npm-scripts.ts: Fix replaceVersion() in Node 20 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, can about making it IIFE and read version from |
|
You mean using `fs.readfileSync(path.join(dirname, '..', 'package.json') and parse it etc? It's an overkill IMHO. |
|
BTW no no, this is mediasoup-client! Did you mean versatica/mediasoup#1197? |
|
Right, I think I commented on the wrong PR 🙂 |
ibc
added a commit
to versatica/mediasoup
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just that. Wrong usage of
fs.readdirSync().