Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in addNackSupportForOpus #314

Merged
merged 1 commit into from
Jan 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/handlers/Chrome111.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class Chrome111 extends HandlerInterface {
});

// libwebrtc supports NACK for OPUS but doesn't announce it.
ortcUtils.addNackSuppportForOpus(nativeRtpCapabilities);
ortcUtils.addNackSupportForOpus(nativeRtpCapabilities);

return nativeRtpCapabilities;
} catch (error) {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/Chrome74.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export class Chrome74 extends HandlerInterface {
});

// libwebrtc supports NACK for OPUS but doesn't announce it.
ortcUtils.addNackSuppportForOpus(nativeRtpCapabilities);
ortcUtils.addNackSupportForOpus(nativeRtpCapabilities);

return nativeRtpCapabilities;
} catch (error) {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/ReactNativeUnifiedPlan.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class ReactNativeUnifiedPlan extends HandlerInterface {
});

// libwebrtc supports NACK for OPUS but doesn't announce it.
ortcUtils.addNackSuppportForOpus(nativeRtpCapabilities);
ortcUtils.addNackSupportForOpus(nativeRtpCapabilities);

return nativeRtpCapabilities;
} catch (error) {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/Safari12.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export class Safari12 extends HandlerInterface {
});

// libwebrtc supports NACK for OPUS but doesn't announce it.
ortcUtils.addNackSuppportForOpus(nativeRtpCapabilities);
ortcUtils.addNackSupportForOpus(nativeRtpCapabilities);

return nativeRtpCapabilities;
} catch (error) {
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/ortc/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { RtpCapabilities } from '../../RtpParameters';
/**
* This function adds RTCP NACK support for OPUS codec in given capabilities.
*/
export function addNackSuppportForOpus(rtpCapabilities: RtpCapabilities): void {
export function addNackSupportForOpus(rtpCapabilities: RtpCapabilities): void {
for (const codec of rtpCapabilities.codecs ?? []) {
if (
(codec.mimeType.toLowerCase() === 'audio/opus' ||
Expand Down