Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use Node.js version 20 #1177

Merged
merged 6 commits into from
Oct 16, 2023
Merged

CI: Use Node.js version 20 #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
42f5280
CI: Use Node.js version 20
jmillan Oct 16, 2023
13229c0
Update CHANGELOG.md
jmillan Oct 16, 2023
f9b3473
Update Dockerfile
jmillan Oct 16, 2023
e9cbc3b
CodeQL: skip worker prebuilt download
jmillan Oct 16, 2023
8065234
Windows: try to fix the deletion of msys
jmillan Oct 16, 2023
06b95b1
Revert "Windows: try to fix the deletion of msys"
jmillan Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ jobs:
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support

env:
MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I completely missed this!


steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/mediasoup-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ jobs:
- os: ubuntu-22.04
node: 20
- os: macos-12
node: 18
node: 20
- os: windows-2022
node: 18
node: 20

runs-on: ${{ matrix.ci.os }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mediasoup-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
cxx: cl
# A single Node.js version should be fine for C++.
node:
- 18
- 20

runs-on: ${{ matrix.build.os }}

Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Changelog


### NEXT

* CI: Use Node.js version 20 ([PR #1177](https://github.com/versatica/mediasoup/pull/1177)).


### 3.12.13

* Bump up Meson from 1.1.0 to 1.2.1 (fixes Xcode 15 build issues) ([PR #1163](https://github.com/versatica/mediasoup/pull/1163) by @arcinston).
Expand Down
15 changes: 12 additions & 3 deletions worker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,18 @@ RUN \
libdbus-1-dev libboost-dev autoconf-archive bash-completion python3-yaml \
clang

# Install node 16.
RUN curl -sL https://deb.nodesource.com/setup_18.x | bash -
RUN apt-get install -y nodejs
# Install node 20.
RUN set -x \
&& apt-get update \
&& apt-get install --yes ca-certificates curl gnupg \
&& mkdir -p /etc/apt/keyrings \
&& curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
| gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg \
&& NODE_MAJOR=20 \
&& echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" \
> /etc/apt/sources.list.d/nodesource.list \
&& apt-get update \
&& apt-get install nodejs --yes

# Make CC and CXX point to clang/clang++ installed above.
ENV LANG="C.UTF-8"
Expand Down