[flatbuffers] Improve Node imports #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `node:` prefix to all built-in Node imports (replaces PR #1142). - Replace `uuid` package with built-in `crypto.randomUUID()`(replaces PR #1140). - Cosmetic changes in TS files: - Avoid unnecessary `const { createWorker } = mediasoup` in almost all tests. - Move all FBS related imports to the bottom. - Some formating fixes that bypassed our ESLint rules.
This was referenced Oct 25, 2023
jmillan
approved these changes
Oct 25, 2023
piranna
suggested changes
Oct 25, 2023
| export function generateUUIDv4(): string | ||
| { | ||
| return randomUUID(); | ||
| } |
There was a problem hiding this comment.
Why is that? Why not using directly the node:crypto export?
There was a problem hiding this comment.
To make it clear that it's a UUID version 4 and to be consistent with other utils such as generateRandomNumber() which also uses crypto API inside. It's not bad to have wrappers that allow us to change the internal implementation at any time if needed.
There was a problem hiding this comment.
Not my taste of cake, but ok 👍🏻
piranna
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node:prefix to all built-in Node imports (replaces PR Addnode:prefix to built-in modules #1142).uuidpackage with built-incrypto.randomUUID()(replaces PR Replaceuuidpackage with built-incrypto.randomUUID()#1140).const { createWorker } = mediasoupin almost all tests.